Clean up condition variable usage in SequencedWorkerPool

base/threading/sequenced_worker_pool_unittest.cc

Index: base/threading/sequenced_worker_pool_unittest.cc
diff --git a/base/threading/sequenced_worker_pool_unittest.cc b/base/threading/sequenced_worker_pool_unittest.cc
index 946ded68d9573a04935040481670edc57e4cfc11..038c81c859cf7247c10986845ebf0ae1665afc13 100644
--- a/base/threading/sequenced_worker_pool_unittest.cc
+++ b/base/threading/sequenced_worker_pool_unittest.cc
@@ -480,6 +480,18 @@ TEST_F(SequencedWorkerPoolTest, ContinueOnShutdown) {
   EXPECT_EQ(1u, result.size());
 }
 
+// Ensure all worker threads are created, and then trigger a spurious
+// work signal.  This shouldn't cause any other work signals to be

[Sigurður Ásgeirsson, 2012/03/12 13:01:40]

nit: one space after full stop, same below.

[akalin, 2012/03/12 18:34:34]

Done.

+// triggered.  This is a regression test for http://crbug.com/117469.
+TEST_F(SequencedWorkerPoolTest, SpuriousWorkSignal) {

[Sigurður Ásgeirsson, 2012/03/12 13:01:40]

Nice!

+  EnsureAllWorkersCreated();
+  int old_work_signal_count = pool()->GetWorkSignalCountForTesting();
+  pool()->TriggerSpuriousWorkSignalForTesting();
+  // This is inherently racy, but can only produce false positives.
+  base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
+  EXPECT_EQ(old_work_signal_count + 1, pool()->GetWorkSignalCountForTesting());
+}
+
 class SequencedWorkerPoolTaskRunnerTestDelegate {
  public:
   SequencedWorkerPoolTaskRunnerTestDelegate() {}