Clean up condition variable usage in SequencedWorkerPool

base/threading/sequenced_worker_pool_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 462 matching lines @@
   EXPECT_FALSE(pool()->PostWorkerTaskWithShutdownBehavior(
       FROM_HERE, base::Bind(&TestTracker::FastTask, tracker(), 0),
       SequencedWorkerPool::CONTINUE_ON_SHUTDOWN));
 
   // Continue the background thread and make sure the task can complete.
   blocker.Unblock(1);
   std::vector<int> result = tracker()->WaitUntilTasksComplete(1);
   EXPECT_EQ(1u, result.size());
 }
 
+// Ensure all worker threads are created, and then trigger a spurious
+// work signal.  This shouldn't cause any other work signals to be

[Sigurður Ásgeirsson, 2012/03/12 13:01:40]

nit: one space after full stop, same below.

[akalin, 2012/03/12 18:34:34]

Done.

+// triggered.  This is a regression test for http://crbug.com/117469.
+TEST_F(SequencedWorkerPoolTest, SpuriousWorkSignal) {

[Sigurður Ásgeirsson, 2012/03/12 13:01:40]

Nice!

+  EnsureAllWorkersCreated();
+  int old_work_signal_count = pool()->GetWorkSignalCountForTesting();
+  pool()->TriggerSpuriousWorkSignalForTesting();
+  // This is inherently racy, but can only produce false positives.
+  base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
+  EXPECT_EQ(old_work_signal_count + 1, pool()->GetWorkSignalCountForTesting());
+}
+
 class SequencedWorkerPoolTaskRunnerTestDelegate {
  public:
   SequencedWorkerPoolTaskRunnerTestDelegate() {}
 
   ~SequencedWorkerPoolTaskRunnerTestDelegate() {}
 
   void StartTaskRunner() {
     pool_owner_.reset(
         new SequencedWorkerPoolOwner(10, "SequencedWorkerPoolTaskRunnerTest"));
   }
@@ skipping 19 matching lines @@
   scoped_ptr<SequencedWorkerPoolOwner> pool_owner_;
 };
 
 INSTANTIATE_TYPED_TEST_CASE_P(
     SequencedWorkerPool, TaskRunnerTest,
     SequencedWorkerPoolTaskRunnerTestDelegate);
 
 }  // namespace
 
 }  // namespace base