Pass content-type resources to web intents. Goes through download, then invokes the p…

content/browser/renderer_host/buffered_resource_handler.cc

Index: content/browser/renderer_host/buffered_resource_handler.cc
diff --git a/content/browser/renderer_host/buffered_resource_handler.cc b/content/browser/renderer_host/buffered_resource_handler.cc
index 3cfbbbab95f24c3ea06e0ef6bbe0c921a88d3d10..9fe88d7e2cafc035877a73ce89f2cdabc04673ff 100644
--- a/content/browser/renderer_host/buffered_resource_handler.cc
+++ b/content/browser/renderer_host/buffered_resource_handler.cc
@@ -184,6 +184,7 @@ bool BufferedResourceHandler::DelayResponse() {
     response_->mime_type.assign(mime_type);
   }
 
+  /*

[jam, 2012/03/16 21:36:26]

?

   if (mime_type == "application/rss+xml" ||
       mime_type == "application/atom+xml") {
     // Sad face.  The server told us that they wanted us to treat the response
@@ -196,6 +197,7 @@ bool BufferedResourceHandler::DelayResponse() {
     mime_type.assign("text/plain");
     response_->mime_type.assign(mime_type);
   }
+  */
 
   if (!not_modified_status && ShouldWaitForPlugins()) {
     wait_for_plugins_ = true;
@@ -362,6 +364,12 @@ bool BufferedResourceHandler::ShouldDownload(bool* need_plugin_list) {
       host_->delegate()->ShouldForceDownloadResource(request_->url(), type))
     return true;
 
+  // mime type support currently says it supports feed types.
+  if (type == "application/rss+xml" ||

[jam, 2012/03/16 21:36:26]

why is this code here? it's hard to understand this. isn't/shouldn't there be a
centralized place for mime types that are handled by web intents instead of
spreading this across different files?

[Greg Billock, 2012/03/18 00:32:21]

This is working around a hack in IsSupportedMimeType, which claims the browser
"supports" feed types (which it does by mashing them to text/plain as above). I
plan to put these policy changes in separate CLs, but I do plan on supporting
feed content types with web intents; I think it'll be a big step forward (see
the bug number earlier in the thread).

+      type == "application/atom+xml") {
+    return true;
+  }
+
   // MIME type checking.
   if (net::IsSupportedMimeType(type))
     return false;