Pass content-type resources to web intents. Goes through download, then invokes the p…

content/browser/renderer_host/buffered_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/buffered_resource_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 166 matching lines @@
   }
 
   if (sniffing_blocked && mime_type.empty() && !not_modified_status) {
     // Ugg.  The server told us not to sniff the content but didn't give us a
     // mime type.  What's a browser to do?  Turns out, we're supposed to treat
     // the response as "text/plain".  This is the most secure option.
     mime_type.assign("text/plain");
     response_->mime_type.assign(mime_type);
   }
 
+  /*

[jam, 2012/03/16 21:36:26]

?

   if (mime_type == "application/rss+xml" ||
       mime_type == "application/atom+xml") {
     // Sad face.  The server told us that they wanted us to treat the response
     // as RSS or Atom.  Unfortunately, we don't have a built-in feed previewer
     // like other browsers.  We can't just render the content as XML because
     // web sites let third parties inject arbitrary script into their RSS
     // feeds.  That leaves us with little choice but to practically ignore the
     // response.  In the future, when we have an RSS feed previewer, we can
     // remove this logic.
     mime_type.assign("text/plain");
     response_->mime_type.assign(mime_type);
   }
+  */
 
   if (!not_modified_status && ShouldWaitForPlugins()) {
     wait_for_plugins_ = true;
     return true;
   }
 
   return false;
 }
 
 bool BufferedResourceHandler::DidBufferEnough(int bytes_read) {
@@ skipping 146 matching lines @@
   if (!disposition.empty()) {
     net::HttpContentDisposition parsed_disposition(disposition, std::string());
     if (parsed_disposition.is_attachment())
       return true;
   }
 
   if (host_->delegate() &&
       host_->delegate()->ShouldForceDownloadResource(request_->url(), type))
     return true;
 
+  // mime type support currently says it supports feed types.
+  if (type == "application/rss+xml" ||

[jam, 2012/03/16 21:36:26]

why is this code here? it's hard to understand this. isn't/shouldn't there be a
centralized place for mime types that are handled by web intents instead of
spreading this across different files?

[Greg Billock, 2012/03/18 00:32:21]

This is working around a hack in IsSupportedMimeType, which claims the browser
"supports" feed types (which it does by mashing them to text/plain as above). I
plan to put these policy changes in separate CLs, but I do plan on supporting
feed content types with web intents; I think it'll be a big step forward (see
the bug number earlier in the thread).

+      type == "application/atom+xml") {
+    return true;
+  }
+
   // MIME type checking.
   if (net::IsSupportedMimeType(type))
     return false;
 
   // Finally, check the plugin list.
   bool allow_wildcard = false;
   ResourceRequestInfoImpl* info =
       ResourceRequestInfoImpl::ForRequest(request_);
   bool stale = false;
   webkit::WebPluginInfo plugin;
@@ skipping 91 matching lines @@
       ResourceRequestInfoImpl::ForRequest(request_);
   int child_id = info->GetChildID();
   int request_id = info->GetRequestID();
 
   host_->PauseRequest(child_id, request_id, false);
   if (!CompleteResponseStarted(request_id))
     host_->CancelRequest(child_id, request_id, false);
 }
 
 }  // namespace content