Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_model.h

Issue 9649020: [Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mac fix Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_model.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_model.h b/chrome/browser/ui/intents/web_intent_picker_model.h
index 572be312fa7a84ea7ec7cebac6f29d8626d4e88e..c560cd9b2a0c5c93b3c5a7704bfa197175bdbb7c 100644
--- a/chrome/browser/ui/intents/web_intent_picker_model.h
+++ b/chrome/browser/ui/intents/web_intent_picker_model.h
@@ -116,15 +116,15 @@ class WebIntentPickerModel {
void SetSuggestedExtensionIconWithId(const string16& id,
const gfx::Image& image);
- // Set the picker to display the intent service at |index| inline.
- void SetInlineDisposition(size_t index);
+ // Set the picker to display the intent service with |url| inline.
+ void SetInlineDisposition(const GURL& url);
// Returns true if the picker is currently displaying an inline service.
bool IsInlineDisposition() const;
- // Returns the index of the intent service that is being displayed inline, or
- // std::string::npos if none.
- size_t inline_disposition_index() const { return inline_disposition_index_; }
+ // Returns the url of the intent service that is being displayed inline, or
+ // GURL::EmptyGURL() if none.
+ GURL inline_disposition_url() const { return inline_disposition_url_; }
private:
// Delete all elements in |installed_services_| and |suggested_extensions_|.
@@ -142,9 +142,9 @@ class WebIntentPickerModel {
// The observer to send notifications to, or NULL if none.
WebIntentPickerModelObserver* observer_;
- // The index of the intent service that is being displayed inline, or
- // std::string::npos if none.
- size_t inline_disposition_index_;
+ // The url of the intent service that is being displayed inline, or
+ // GURL::EmptyGURL() if none.
+ GURL inline_disposition_url_;
DISALLOW_COPY_AND_ASSIGN(WebIntentPickerModel);
};
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_delegate.h ('k') | chrome/browser/ui/intents/web_intent_picker_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698