chrome/browser/ui/intents/web_intent_picker_delegate.h - Issue 9649020: [Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_delegate.h

Issue 9649020: [Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mac fix Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc ('k') | chrome/browser/ui/intents/web_intent_picker_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_delegate.h

diff --git a/chrome/browser/ui/intents/web_intent_picker_delegate.h b/chrome/browser/ui/intents/web_intent_picker_delegate.h

index b2098c1da0ab5eefcfc8c473f55dad5b067fe776..f6ef88f84348d7849781f53c3adcc0b14ea9502a 100644

--- a/chrome/browser/ui/intents/web_intent_picker_delegate.h

+++ b/chrome/browser/ui/intents/web_intent_picker_delegate.h

@@ -22,7 +22,7 @@ class WebIntentPickerDelegate {

virtual ~WebIntentPickerDelegate() {}

// Called when the user has chosen a service.

- virtual void OnServiceChosen(size_t index, Disposition disposition) = 0;

+ virtual void OnServiceChosen(const GURL& url, Disposition disposition) = 0;

// Called when the picker has created WebContents to use for inline

// disposition.