Issue 9649020: [Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services.

Issue 9649020: [Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services. (Closed)

Created:
8 years, 9 months ago by binji

Modified:
8 years, 9 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services. (minor yak-shave necessary to support extension install). BUG=none TEST=WebIntentPickerModel.*, WebIntentPickerControllerBrowserTest.* TBR=estade@chromium.org TBR=sky@chromium.org TBR=sail@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126191

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : mac fix #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -76 lines)			Patch
M	chrome/browser/ui/cocoa/web_intent_picker_cocoa.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/web_intent_picker_gtk.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/web_intent_picker_gtk.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		5 chunks	+6 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc	View		4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.h	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.cc	View		3 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model_observer.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model_unittest.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/web_intent_picker_views.cc	View		6 chunks	+6 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9649020/7001

8 years, 9 months ago (2012-03-12 17:45:29 UTC) #3

Change committed as 126191

Expand Messages | Collapse Messages