Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9633014: Remove dead code left over from old-style WebCompositor initialization path. (Closed)

Created:
8 years, 9 months ago by nduca
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove dead code left over from old-style WebCompositor initialization path. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126612

Patch Set 1 #

Patch Set 2 : Change type of compsoitor_ to WebCompositorInputHandler. #

Total comments: 2

Patch Set 3 : Consistently use input handler #

Patch Set 4 : Compile fix #

Total comments: 2

Patch Set 5 : patch for landing #

Patch Set 6 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -54 lines) Patch
M content/renderer/gpu/compositor_thread.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M content/renderer/gpu/compositor_thread.cc View 1 2 3 4 4 chunks +36 lines, -31 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 2 chunks +1 line, -10 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nduca
8 years, 9 months ago (2012-03-08 10:57:53 UTC) #1
nduca
On 2012/03/08 10:57:53, nduca wrote: This lands first. Then https://bugs.webkit.org/show_bug.cgi?id=80586
8 years, 9 months ago (2012-03-08 11:21:39 UTC) #2
darin (slow to review)
http://codereview.chromium.org/9633014/diff/4/content/renderer/gpu/compositor_thread.cc File content/renderer/gpu/compositor_thread.cc (right): http://codereview.chromium.org/9633014/diff/4/content/renderer/gpu/compositor_thread.cc#newcode87 content/renderer/gpu/compositor_thread.cc:87: WebCompositorInputHandler* compositor = nit: variable name "compositor" should probably ...
8 years, 9 months ago (2012-03-08 18:16:16 UTC) #3
nduca
@darin, ping?
8 years, 9 months ago (2012-03-13 06:54:16 UTC) #4
darin (slow to review)
LGTM w/ nits fixed: http://codereview.chromium.org/9633014/diff/9001/content/renderer/gpu/compositor_thread.cc File content/renderer/gpu/compositor_thread.cc (right): http://codereview.chromium.org/9633014/diff/9001/content/renderer/gpu/compositor_thread.cc#newcode22 content/renderer/gpu/compositor_thread.cc:22: int routing_id, nit: indentation http://codereview.chromium.org/9633014/diff/9001/content/renderer/render_widget.h ...
8 years, 9 months ago (2012-03-13 17:31:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/9633014/10002
8 years, 9 months ago (2012-03-13 20:40:20 UTC) #6
commit-bot: I haz the power
Try job failure for 9633014-10002 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...
8 years, 9 months ago (2012-03-14 01:46:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/9633014/10002
8 years, 9 months ago (2012-03-14 05:36:53 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 08:32:40 UTC) #9 
Change committed as 126612

Powered by Google App Engine
This is Rietveld 408576698