Error reporting on File in dart:io

runtime/bin/file.h

Index: runtime/bin/file.h
diff --git a/runtime/bin/file.h b/runtime/bin/file.h
index 0fdc398640235f500997b2283d2e12f51313be74..6e77f8b7a63558747d097a8932fb7bf07fa71d21 100644
--- a/runtime/bin/file.h
+++ b/runtime/bin/file.h
@@ -19,6 +19,7 @@ typedef unsigned __int8 uint8_t;
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
+#include "bin/utils.h"
 #include "platform/globals.h"
 #include "platform/thread.h"
 
@@ -111,7 +112,9 @@ class File {
   // reading and writing. If mode contains kWrite and the file does
   // not exist the file is created. The file is truncated to length 0 if
   // mode contains kTruncate.
-  static File* Open(const char* name, FileOpenMode mode);
+  static File* Open(const char* name,
+                    FileOpenMode mode,
+                    OSError* os_error = NULL);

[Mads Ager (google), 2012/03/09 09:40:13]

I think we have avoided default arguments in the C code so far. Let's keep it
that way and make this an explicit argument?

[Søren Gjesse, 2012/03/13 08:25:55]

I removed the OSError argument. The OS error is now captured from the system
after returning NULL from File::Open.

 
   // Create a file object for the specified stdio file descriptor
   // (stdin, stout or stderr).