Error reporting on File in dart:io

runtime/bin/file.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_FILE_H_
 #define BIN_FILE_H_
 
 #if defined(_WIN32)
 typedef signed __int64 int64_t;
 typedef unsigned __int8 uint8_t;
 #else
 #include <stdint.h>
 #endif
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 #include <sys/types.h>
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
+#include "bin/utils.h"
 #include "platform/globals.h"
 #include "platform/thread.h"
 
 // Forward declaration.
 class FileHandle;
 
 class File {
  public:
   enum FileOpenMode {
     kRead = 0,
@@ skipping 72 matching lines @@
   // Flush contents of file.
   void Flush();
 
   const char* name() const { return name_; }
 
   // Open the file with the given name. The file is always opened for
   // reading. If mode contains kWrite the file is opened for both
   // reading and writing. If mode contains kWrite and the file does
   // not exist the file is created. The file is truncated to length 0 if
   // mode contains kTruncate.
-  static File* Open(const char* name, FileOpenMode mode);
+  static File* Open(const char* name,
+                    FileOpenMode mode,
+                    OSError* os_error = NULL);

[Mads Ager (google), 2012/03/09 09:40:13]

I think we have avoided default arguments in the C code so far. Let's keep it
that way and make this an explicit argument?

[Søren Gjesse, 2012/03/13 08:25:55]

I removed the OSError argument. The OS error is now captured from the system
after returning NULL from File::Open.

 
   // Create a file object for the specified stdio file descriptor
   // (stdin, stout or stderr).
   static File* OpenStdio(int fd);
 
   static bool Exists(const char* name);
   static bool Create(const char* name);
   static bool Delete(const char* name);
   static bool IsAbsolutePath(const char* pathname);
   static char* GetCanonicalPath(const char* name);
@@ skipping 21 matching lines @@
   File(const File&);
   void operator=(const File&);
 
   static dart::Mutex mutex_;
   static int service_ports_size_;
   static Dart_Port* service_ports_;
   static int service_ports_index_;
 };
 
 #endif  // BIN_FILE_H_