Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 9630002: Ash: Remove compact window mode. (Closed)

Created:
8 years, 9 months ago by James Cook
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, dcheng, estade+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Ash: Remove compact window mode. Remove MultipleWindowIndicatorButton Clean up OpaqueBrowserFrameView Remove CompactBrowserFrameView Remove ash/wm/compact_layout_manager and compact_status_area_layout_manager Remove window mode switches Remove window mode from ash::Shell Remove ShellDelegate::CycleOrder Remove ShellDelegate::GetOverrideWindowMode Remove all outside calls to Shell::IsWindowModeCompact BUG=117284 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125625

Patch Set 1 #

Patch Set 2 : OpaqueBrowserFrameView, MultipleWindowIndicatorButton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1667 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/ash_switches.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M ash/focus_cycler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_window_cycler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 7 chunks +3 lines, -39 lines 0 comments Download
M ash/shell.cc View 10 chunks +9 lines, -90 lines 0 comments Download
M ash/shell/shell_main.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M ash/shell_delegate.h View 3 chunks +1 line, -12 lines 0 comments Download
M ash/shell_unittest.cc View 3 chunks +0 lines, -83 lines 0 comments Download
M ash/test/ash_test_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M ash/test/test_shell_delegate.h View 2 chunks +1 line, -8 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 3 chunks +4 lines, -22 lines 0 comments Download
D ash/wm/compact_layout_manager.h View 1 chunk +0 lines, -94 lines 0 comments Download
D ash/wm/compact_layout_manager.cc View 1 chunk +0 lines, -256 lines 0 comments Download
D ash/wm/compact_layout_manager_unittest.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D ash/wm/compact_status_area_layout_manager.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ash/wm/compact_status_area_layout_manager.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_non_client_frame_view_factory_chromeos.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 2 chunks +4 lines, -24 lines 0 comments Download
D chrome/browser/ui/views/ash/multiple_window_indicator_button.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/views/ash/multiple_window_indicator_button.cc View 1 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/browser/ui/views/ash/status_area_host_aura.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/ash/status_area_host_aura.cc View 6 chunks +1 line, -59 lines 0 comments Download
M chrome/browser/ui/views/ash/status_area_host_aura_browsertest.cc View 3 chunks +4 lines, -36 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 4 chunks +3 lines, -79 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 2 chunks +0 lines, -75 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/ui/views/frame/compact_browser_frame_view.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/views/frame/compact_browser_frame_view.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 6 chunks +0 lines, -74 lines 0 comments Download
M chrome/browser/ui/views/tabs/default_tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/window.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/window_snapshot/window_snapshot_aura.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
Sky, PTAL. This should be reasonably straightforward, but I think the chrome/browser bits around widget ...
8 years, 9 months ago (2012-03-08 02:03:10 UTC) #1
sky
8 years, 9 months ago (2012-03-08 03:46:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698