Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/about_flags.cc

Issue 9630002: Ash: Remove compact window mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OpaqueBrowserFrameView, MultipleWindowIndicatorButton Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index a69b7e61e1441a90059dbcb0f846df24ab62aae8..c4cfb944275229c1ebb8b07ce1395aab9b258b6a 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -87,18 +87,6 @@ const Experiment::Choice kOmniboxInlineHistoryQuickProviderChoices[] = {
switches::kOmniboxInlineHistoryQuickProviderProhibited }
};
-#if defined(USE_AURA)
-const Experiment::Choice kAuraWindowModeChoices[] = {
- { IDS_FLAGS_AURA_WINDOW_MODE_AUTOMATIC, "", "" },
- { IDS_FLAGS_AURA_WINDOW_MODE_COMPACT,
- ash::switches::kAuraWindowMode,
- ash::switches::kAuraWindowModeCompact },
- { IDS_FLAGS_AURA_WINDOW_MODE_MANAGED,
- ash::switches::kAuraWindowMode,
- ash::switches::kAuraWindowModeManaged },
-};
-#endif
-
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -457,13 +445,6 @@ const Experiment kExperiments[] = {
kOsWin | kOsLinux | kOsCrOS,
SINGLE_VALUE_TYPE(ash::switches::kAuraGoogleDialogFrames)
},
- {
- "aura-window-mode",
- IDS_FLAGS_AURA_WINDOW_MODE_NAME,
- IDS_FLAGS_AURA_WINDOW_MODE_DESCRIPTION,
- kOsWin | kOsLinux | kOsCrOS,
- MULTI_VALUE_TYPE(kAuraWindowModeChoices)
- },
#endif // defined(USE_AURA)
{
"enable-gamepad",
@@ -798,16 +779,6 @@ ListValue* GetFlagsExperimentsData(PrefService* prefs) {
l10n_util::GetStringUTF16(
experiment.visible_description_id));
bool supported = !!(experiment.supported_platforms & current_platform);
-#if defined(USE_AURA) && defined(OS_CHROMEOS)
- // Some Chrome OS devices currently require Aura compact window mode, so
- // don't offer a choice of mode.
- // TODO(jamescook): Remove after Aura supports normal mode on all devices,
- // likely around M19.
- if (experiment.visible_name_id == IDS_FLAGS_AURA_WINDOW_MODE_NAME &&
- CommandLine::ForCurrentProcess()->
- HasSwitch(ash::switches::kAuraForceCompactWindowMode))
- supported = false;
-#endif
data->SetBoolean("supported", supported);
ListValue* supported_platforms = new ListValue();

Powered by Google App Engine
This is Rietveld 408576698