Move README.chromium and LICENSE in third_party/android/ to correct location

Move third_party/android/testrunner to third_party/android_testrunner
    
The original intent was to have multiple subdirectories under
third_party/android/, but the need for these has not arisen and it potentially
adds complexity.
    
Also update the license checker tool to prune this directory, as the code is
used only for testing.
'tools/licenses.py scan | grep android'

See http://codereview.chromium.org/8322008.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125451

[Mark Mentovai, 2012-03-07 17:17:30]

Maybe it should be third_party/android_testrunner? The LICENSE and
README.chromium only apply to testrunner.

[Steve Block, 2012-03-07 17:23:34]

Hmm, I'm not sure whether Michael plans to add more Android code. Michael, can
you let us know?

If so, do you prefer numerous sub-directories under third_party/android, or
should each be a top-level third-party directory like third_party/android_foo?

The LICENSE is general to all Android code, so another option is to make
third_party/android/README.chromium generic and reference LICENSE, then add more
specific README.chromium files in sub-directories. WDYT?

[Mark Mentovai, 2012-03-07 17:50:29]

I’d worry that this would interfere with the process that generates
about:credits in some way, especially if some future component winds up in
third_party/android but isn’t using an Apache license. You should ask mal about
that, too.

[michaelbai, 2012-03-07 17:56:07]

The plan was to put the Android code we depend on in third_party/android/
directory, and each component has
its own sub-directory, but until now I haven't see another
component need to be here.

I doubt we can have a general README.chromium as we need record at least below
information.
a. where the component comes from,
b. The version number.
c. Is there any local modification.

Can we change the license checker tool instead?

On 2012/03/07 17:23:34, Steve Block wrote:
> Hmm, I'm not sure whether Michael plans to add more Android code. Michael, can
> you let us know?
> 
> If so, do you prefer numerous sub-directories under third_party/android, or
> should each be a top-level third-party directory like third_party/android_foo?
> 
> The LICENSE is general to all Android code, so another option is to make
> third_party/android/README.chromium generic and reference LICENSE, then add
more
> specific README.chromium files in sub-directories. WDYT?

[Steve Block, 2012-03-07 18:05:27]

> I doubt we can have a general README.chromium
I meant that we would use a general README.chromium to record the fact that this
is all Android code, that it all uses an Apache 2.0 license, and to reference a
single LICENSE file. We would then add other README.chromium files to record the
specifics you list for each subdirectory.

> especially if some future component winds up in
> third_party/android but isn’t using an Apache license
Yes, we'd have to make sure this doesn't happen.

Given that there are no additional Android directories we expect to need, I
think that renaming to third_party/android_testrunner might be the best
solution.

I'll ask mal for his input.

[mal, 2012-03-07 18:31:56]

I think you should put the code in its own subdir (android_testrunner or
whatver). It should be easy to refactor into an android/ hierarchy later if
needed.

Also, you should add the path to PRUNE_PATHS in tools/licenses.py. There's a
section in there that lists other directories that are just test tools and not
in the shipping product (so don't need to be in about:credits).

[Steve Block, 2012-03-07 18:51:12]

Thanks Mark, I've updated the patch.

[Mark Mentovai, 2012-03-07 18:53:50]

LGTM

[commit-bot: I haz the power, 2012-03-07 19:00:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/9622010/6001

[commit-bot: I haz the power, 2012-03-07 21:12:37]

Change committed as 125451