Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/isolate/isolate.py

Issue 9621014: Separate xvfb.py logic into its own script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« testing/xvfb.py ('K') | « testing/xvfb.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate.py
diff --git a/tools/isolate/isolate.py b/tools/isolate/isolate.py
index d70296add3c96b0926751a239187b614aa204479..ad106b94598bc705b5d4fa66212a091671305936 100755
--- a/tools/isolate/isolate.py
+++ b/tools/isolate/isolate.py
@@ -121,14 +121,10 @@ def run(outdir, resultfile, indir, infiles, read_only, cmd):
if read_only:
tree_creator.make_writable(outdir, True)
- # TODO(maruel): Remove me. Layering violation. Used by
- # base/base_paths_linux.cc
- env = os.environ.copy()
- env['CR_SOURCE_ROOT'] = outdir.encode()
# Rebase the command to the right path.
cmd[0] = os.path.join(outdir, cmd[0])
logging.info('Running %s' % cmd)
- result = subprocess.call(cmd, cwd=outdir, env=env)
+ result = subprocess.call(cmd, cwd=outdir)
if not result and resultfile:
# Signal the build tool that the test succeeded.
touch(resultfile)
« testing/xvfb.py ('K') | « testing/xvfb.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698