Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9621: Improving the form autofill menu behavior (Closed)

Created:
12 years, 1 month ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL makes the form autofill popup menu behave like the Firefox's one, we only set the text field text when the user presses enter or click on an item. It also prevents the WM_CHAR events to make it to the page after a WM_KEYDOWN has been processed by the menu (that would typically cause forms to proceed when you pressed enter in the form popup). BUG=4145 TEST=Type something in a form to have the autofill popup showing. Use the down/up arrow to move around. The text should not change in the text field. Press enter, the selection should be set. Try again clicking this time. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5149

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M webkit/glue/webview_impl.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M webkit/port/platform/chromium/PopupMenuChromium.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/port/platform/chromium/PopupMenuChromium.cpp View 1 5 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
12 years, 1 month ago (2008-11-06 02:05:24 UTC) #1
Matt Perry
12 years, 1 month ago (2008-11-06 02:14:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698