Improving the form autofill menu behavior

webkit/port/platform/chromium/PopupMenuChromium.cpp

 // Copyright (c) 2008, Google Inc.
 // All rights reserved.
 // 
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 // 
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 112 matching lines @@
     {
         m_baseWidth = width;
     }
 
     // Compute size of widget and children.
     void layout();
 
     // Returns whether the popup wants to process events for the passed key.
     bool isInterestedInEventForKey(int key_code);
 
+    // Sets whether the PopupMenuClient should be told to change its text when a
+    // new item is selected (by using the arrow keys).  Default is true.
+    void setTextOnIndexChange(bool value) { m_setTextOnIndexChange = value; }
+
 private:
     friend class PopupContainer;
     friend class RefCounted<PopupListBox>;
 
     // A type of List Item
     enum ListItemType {
         TYPE_OPTION,
         TYPE_GROUP,
         TYPE_SEPARATOR
     };
 
     // A item (represented by <option> or <optgroup>) in the <select> widget. 
     struct ListItem {
         ListItem(const String& label, ListItemType type)
             : label(label.copy()), type(type), y(0) {}
         String label;
         ListItemType type;
         int y;  // y offset of this item, relative to the top of the popup.
     };
 
     PopupListBox(PopupMenuClient* client)
         : m_originalIndex(0)
         , m_selectedIndex(0)
         , m_acceptOnAbandon(false)
         , m_visibleRows(0)
         , m_popupClient(client)
         , m_repeatingChar(0)
         , m_lastCharTime(0)
+        , m_setTextOnIndexChange(true)
     {
         setScrollbarModes(ScrollbarAlwaysOff, ScrollbarAlwaysOff);
     }
 
     ~PopupListBox()
     {
         clear();
     }
 
     void disconnectClient() { m_popupClient = 0; }
@@ skipping 73 matching lines @@
     RefPtr<Scrollbar> m_lastScrollbarUnderMouse;
 
     // The string the user has typed so far into the popup. Used for typeAheadFind.
     String m_typedString;
 
     // The char the user has hit repeatedly.  Used for typeAheadFind.
     UChar m_repeatingChar;
 
     // The last time the user hit a key.  Used for typeAheadFind.
     TimeStamp m_lastCharTime;
+
+    bool m_setTextOnIndexChange;
 };
 
 static PlatformMouseEvent constructRelativeMouseEvent(const PlatformMouseEvent& e,
                                                       FramelessScrollView* parent,
                                                       FramelessScrollView* child)
 {
     IntPoint pos = parent->convertSelfToChild(child, e.pos());
 
     // FIXME(beng): This is a horrible hack since PlatformMouseEvent has no setters for x/y.
     //              Need to add setters and get patch back upstream to webkit source. 
@@ skipping 193 matching lines @@
     IntPoint location = v->contentsToWindow(r.location());
 
     // Move it below the select widget.
     location.move(0, r.height());
 
     IntRect popupRect(location, r.size());
     setFrameRect(popupRect);
     showPopup(v);
 }
 
+void PopupContainer::setTextOnIndexChange(bool value) {
+  listBox()->setTextOnIndexChange(value);
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // PopupListBox implementation
 
 bool PopupListBox::handleMouseDownEvent(const PlatformMouseEvent& event)
 {
     Scrollbar* scrollbar = scrollbarUnderMouse(event);
     if (scrollbar) {
         m_capturingScrollbar = scrollbar;
         m_capturingScrollbar->mouseDown(event);
         return true;
@@ skipping 118 matching lines @@
         break;
     }
 
     if (m_originalIndex != m_selectedIndex) {
         // Keyboard events should update the selection immediately (but we don't
         // want to fire the onchange event until the popup is closed, to match
         // IE).  We change the original index so we revert to that when the
         // popup is closed.
         m_acceptOnAbandon = true;
         setOriginalIndex(m_selectedIndex);
-        m_popupClient->setTextFromItem(m_selectedIndex);
+        if (m_setTextOnIndexChange)
+          m_popupClient->setTextFromItem(m_selectedIndex);
     }
 
     return true;
 }
 
 HostWindow* PopupListBox::hostWindow() const
 {
     // Our parent is the root ScrollView, so it is the one that has a
     // HostWindow.  FrameView::hostWindow() works similarly.
     return parent() ? parent()->hostWindow() : 0;
@@ skipping 442 matching lines @@
 {
     p.m_popup->listBox()->updateFromElement();
 }
 
 bool PopupMenu::itemWritingDirectionIsNatural() 
 { 
     return false; 
 }
 
 } // namespace WebCore