Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 9619025: Move FindPasteboard to ui/base/cocoa since it's used by two modules (content+chrome). (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move FindPasteboard to ui/base/cocoa since it's used by two modules (content+chrome). BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125515

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -156 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_pasteboard_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/find_pasteboard.h View 1 chunk +0 lines, -59 lines 0 comments Download
D content/browser/find_pasteboard.mm View 1 chunk +0 lines, -82 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A + ui/base/clipboard/find_pasteboard.h View 3 chunks +6 lines, -6 lines 1 comment Download
A + ui/base/clipboard/find_pasteboard.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jam
8 years, 9 months ago (2012-03-07 21:44:53 UTC) #1
Avi (use Gerrit)
lgtm http://codereview.chromium.org/9619025/diff/1/ui/base/clipboard/find_pasteboard.h File ui/base/clipboard/find_pasteboard.h (right): http://codereview.chromium.org/9619025/diff/1/ui/base/clipboard/find_pasteboard.h#newcode56 ui/base/clipboard/find_pasteboard.h:56: // Also provide a c++ interface Capital C++, ...
8 years, 9 months ago (2012-03-07 21:47:27 UTC) #2
dcheng
It feels like this belongs in ui/base/cocoa rather than ui/base/clipboard (which is mostly related to ...
8 years, 9 months ago (2012-03-07 21:49:01 UTC) #3
Avi (use Gerrit)
Why is the drag/drop stuff in there? It's because drag/drop is essentially a clipboard of ...
8 years, 9 months ago (2012-03-07 21:52:46 UTC) #4
dcheng
On 2012/03/07 21:52:46, Avi wrote: > Why is the drag/drop stuff in there? It's because ...
8 years, 9 months ago (2012-03-07 22:04:58 UTC) #5
jam
I don't have strong feelings of where to put this. However it seems that a ...
8 years, 9 months ago (2012-03-07 22:28:03 UTC) #6
Avi (use Gerrit)
8 years, 9 months ago (2012-03-07 23:26:56 UTC) #7
Doesn't matter that much to me. Put it in ui/base/cocoa; that's fine.

Powered by Google App Engine
This is Rietveld 408576698