Ash: Use translucent frames by default

Ash: Use translucent frames by default

Remove --aura-translucent-frames switch.  Tie old-style frames to the existing --aura-window-mode=compact flag.

Also fix a couple of cases where views::Widget wasn't be flagged as transparent, which would lead to black pixels in the window corners and incorrect headers in the inactive state.

(Edit: I had to back out the conversion of constrained windows -- it breaks some unit tests and needs to be changed slightly.)

BUG=113075
TEST=visual, look at active and inactive browser windows, popup windows, task manager (general dialog)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125251

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=125266

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125333

[James Cook, 2012-03-06 19:51:05]

Ben, PTAL.  This gets us the new-style frames by default.

[Ben Goodger (Google), 2012-03-06 21:14:19]

lgtm

http://codereview.chromium.org/9618022/diff/1/chrome/browser/ui/views/window.cc
File chrome/browser/ui/views/window.cc (right):

http://codereview.chromium.org/9618022/diff/1/chrome/browser/ui/views/window....
chrome/browser/ui/views/window.cc:47: // Outside of compact mode, dialog windows
may have translucent frames.
Can you add a TODO to find a better way to set this?

[James Cook, 2012-03-06 21:48:16]

Thanks.  I'll fix the graphical issues with the dialog box headers in a
subsequent patch.

http://codereview.chromium.org/9618022/diff/1/chrome/browser/ui/views/window.cc
File chrome/browser/ui/views/window.cc (right):

http://codereview.chromium.org/9618022/diff/1/chrome/browser/ui/views/window....
chrome/browser/ui/views/window.cc:47: // Outside of compact mode, dialog windows
may have translucent frames.
On 2012/03/06 21:14:19, Ben Goodger (Google) wrote:
> Can you add a TODO to find a better way to set this?

Done.

[commit-bot: I haz the power, 2012-03-06 21:48:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/9618022/1

[commit-bot: I haz the power, 2012-03-06 21:49:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/9618022/7001

[commit-bot: I haz the power, 2012-03-06 23:43:21]

Change committed as 125251

[commit-bot: I haz the power, 2012-03-07 03:40:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/9618022/14

[commit-bot: I haz the power, 2012-03-07 05:28:36]

Change committed as 125333