Ash: Use translucent frames by default

chrome/browser/ui/views/window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/window.h"
 
 #include "ui/views/bubble/bubble_delegate.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(USE_AURA)
@@ skipping 15 matching lines @@
 
 // Note: This file should be removed after the old ChromeOS frontend is removed.
 //       It is not needed for Aura.
 //       The visual style implemented by BubbleFrameView/BubbleWindow for
 //       ChromeOS should move to Ash.
 //       Calling code should just call the standard views Widget creation
 //       methods and "the right thing" should just happen.
 //       The remainder of the code here is dealing with the legacy CrOS WM and
 //       can also be removed.
 
+namespace {
+
+views::Widget* CreateViewsWindowWithParent(gfx::NativeWindow parent,
+                                           views::WidgetDelegate* delegate) {
+  views::Widget* widget = new views::Widget;
+  views::Widget::InitParams params;
+  params.delegate = delegate;
+#if defined(OS_WIN) || defined(USE_AURA)
+  params.parent = parent;
+#endif
+#if defined(USE_AURA)
+  // Outside of compact mode, dialog windows may have translucent frames.

[Ben Goodger (Google), 2012/03/06 21:14:19]

Can you add a TODO to find a better way to set this?

[James Cook, 2012/03/06 21:48:16]

Done.

+  if (!ash::Shell::GetInstance()->IsWindowModeCompact())
+    params.transparent = true;
+#endif
+  widget->Init(params);
+  return widget;
+}
+
+}  // namespace
+
 namespace browser {
 
 views::Widget* CreateViewsWindow(gfx::NativeWindow parent,
                                  views::WidgetDelegate* delegate,
                                  DialogStyle style) {
 #if defined(OS_CHROMEOS) && !defined(USE_AURA)
   return chromeos::BubbleWindow::Create(parent, style, delegate);
 #else
-  return views::Widget::CreateWindowWithParent(delegate, parent);
+  return CreateViewsWindowWithParent(parent, delegate);
 #endif
 }
 
 views::Widget* CreateFramelessViewsWindow(gfx::NativeWindow parent,
                                           views::WidgetDelegate* delegate) {
 #if defined(OS_CHROMEOS) && !defined(USE_AURA)
   return chromeos::BubbleWindow::Create(parent, STYLE_FLUSH, delegate);
 #else
   return CreateFramelessWindowWithParentAndBounds(delegate,
       parent, gfx::Rect());
@@ skipping 47 matching lines @@
   params.push_back(1);  // Show while screen is locked.
   chromeos::WmIpc::instance()->SetWindowType(
       bubble_widget->GetNativeView(),
       chromeos::WM_IPC_WINDOW_CHROME_INFO_BUBBLE,
       &params);
 #endif
   return bubble_widget;
 }
 
 }  // namespace browser