Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 9617032: Fix tweak_info_plist.py to be explicit about arguments. (Closed)

Created:
8 years, 9 months ago by Avi (use Gerrit)
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix tweak_info_plist.py to be explicit about arguments. BUG=115784 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125349

Patch Set 1 #

Patch Set 2 : small renaming #

Patch Set 3 : first upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -110 lines) Patch
A + build/mac/make_more_helpers.sh View 1 2 3 chunks +6 lines, -11 lines 0 comments Download
chrome/chrome_exe.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
chrome/tools/build/mac/dump_product_syms View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
chrome/tools/build/mac/make_more_helpers.sh View 1 2 1 chunk +0 lines, -93 lines 0 comments Download
M content/content_shell.gypi View 1 2 4 chunks +92 lines, -1 line 0 comments Download
content/shell/mac/helper-Info.plist View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
content/shell/shell_browser_main.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
content/shell/shell_browser_main.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A content/shell/shell_browser_main_mac.mm View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M content/shell/shell_main_delegate.cc View 1 2 3 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 9 months ago (2012-03-07 03:14:56 UTC) #1
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-07 03:50:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9617032/3001
8 years, 9 months ago (2012-03-07 04:46:03 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-07 06:25:18 UTC) #4
Change committed as 125349

Powered by Google App Engine
This is Rietveld 408576698