Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: build/mac/make_more_helpers.sh

Issue 9617032: Fix tweak_info_plist.py to be explicit about arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: first upload Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/make_more_helpers.sh
diff --git a/chrome/tools/build/mac/make_more_helpers.sh b/build/mac/make_more_helpers.sh
similarity index 85%
rename from chrome/tools/build/mac/make_more_helpers.sh
rename to build/mac/make_more_helpers.sh
index 0acffc92a5adc37ca6f0d080215d57f5c832a10e..dc6e4d843a5dc7d8e7c94862dd99832c524fc5f7 100755
--- a/chrome/tools/build/mac/make_more_helpers.sh
+++ b/build/mac/make_more_helpers.sh
@@ -4,7 +4,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# Usage: make_more_helpers.sh <version> <app_name>
+# Usage: make_more_helpers.sh <containing_directory> <app_name>
#
# This script creates additional helper .app bundles for Chromium, based on
# the existing helper .app bundle, changing their Mach-O header's flags to
@@ -50,8 +50,7 @@ make_helper() {
local helper_feature_exe="${feature_helper}/Contents/MacOS/${helper_feature}"
mv "${feature_helper}/Contents/MacOS/${helper_name}" "${helper_feature_exe}"
- local change_flags="\
-$(dirname "${0}")/../../../../build/mac/change_mach_o_flags.py"
+ local change_flags="$(dirname "${0}")/change_mach_o_flags.py"
"${change_flags}" ${flags} "${helper_feature_exe}"
local feature_info="${feature_helper}/Contents/Info"
@@ -78,16 +77,12 @@ $(dirname "${0}")/../../../../build/mac/change_mach_o_flags.py"
}
if [[ ${#} -ne 2 ]]; then
- echo "usage: ${0} <version> <app_name>" >& 2
+ echo "usage: ${0} <containing_directory> <app_name>" >& 2
exit 1
fi
-VERSION="${1}"
+CONTAINING_DIRECTORY="${1}"
APP_NAME="${2}"
-CONTENTS_DIR="${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}"
-VERSIONED_DIR="${CONTENTS_DIR}/Versions"
-CURRENT_VERSIONED_DIR="${VERSIONED_DIR}/${VERSION}"
-
-make_helper "${CURRENT_VERSIONED_DIR}" "${APP_NAME}" "EH" "--executable-heap"
-make_helper "${CURRENT_VERSIONED_DIR}" "${APP_NAME}" "NP" "--no-pie"
+make_helper "${CONTAINING_DIRECTORY}" "${APP_NAME}" "EH" "--executable-heap"
+make_helper "${CONTAINING_DIRECTORY}" "${APP_NAME}" "NP" "--no-pie"
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698