Improve formatting of accessibility tests that dump the tree.

content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

Index: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
diff --git a/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm b/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
index 949fe9c7932d5a329ddf4ac1586c35555466b42b..6105adc55f7e9dee5e95ddb8d58e43b8ba9bac4f 100644
--- a/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
+++ b/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
@@ -13,13 +13,16 @@
 
 void DumpAccessibilityTreeHelper::Initialize() {}
 
-string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node) {
+string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node,
+                                               char* prefix) {
   BrowserAccessibilityCocoa* cocoa_node = node->toBrowserAccessibilityCocoa();
-  NSString* dump = [NSString stringWithFormat:@"%@|%@|%@|%@",
-      [cocoa_node role],
-      [cocoa_node subrole],
-      [cocoa_node title],
-      [cocoa_node value]];
+  NSString* dump =
+      [NSString stringWithFormat:@"%s%@ subrole=%@ title='%@' value='%@'\n",

[David Tseng, 2012/03/06 23:49:05]

Could you also include "role=", and perhaps we should have a cross platform
template and use vswprintf in the platform implementations.

[dmazzoni, 2012/03/08 07:10:37]

Are you okay to try it without role? I tried adding role but the resulting file
is less readable, at least visually. I like that the very first thing on each
line is the role, it makes it much easier to skim a hierarchy and find a line
you're looking for.

If you still don't like it after we've added more tests, I'm fine to add role=
later, or alternatively try some other format like xml or json.

I don't think we should strive to have a strict cross-platform template, because
remember there are several fields that will only apply to either mac or win, so
we should allow them to diverge as necessary. Let's just have them use similar
syntax.

+       prefix,
+       [cocoa_node role],
+       [cocoa_node subrole],
+       [cocoa_node title],
+       [cocoa_node value]];
   std::string tempVal = [dump cStringUsingEncoding:NSUTF8StringEncoding];
 
   return UTF8ToUTF16(tempVal);
@@ -34,7 +37,3 @@ const FilePath::StringType DumpAccessibilityTreeHelper::GetExpectedFileSuffix()
     const {
   return FILE_PATH_LITERAL("-expected-mac.txt");
 }
-
-const string16 DumpAccessibilityTreeHelper::GetLineEnding() const {
-  return UTF8ToUTF16("\n");
-}