Improve formatting of accessibility tests that dump the tree.

content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/dump_accessibility_tree_helper.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_path.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/accessibility/browser_accessibility_cocoa.h"
 #include "content/browser/accessibility/browser_accessibility_mac.h"
 
 void DumpAccessibilityTreeHelper::Initialize() {}
 
-string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node) {
+string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node,
+                                               char* prefix) {
   BrowserAccessibilityCocoa* cocoa_node = node->toBrowserAccessibilityCocoa();
-  NSString* dump = [NSString stringWithFormat:@"%@|%@|%@|%@",
-      [cocoa_node role],
-      [cocoa_node subrole],
-      [cocoa_node title],
-      [cocoa_node value]];
+  NSString* dump =
+      [NSString stringWithFormat:@"%s%@ subrole=%@ title='%@' value='%@'\n",

[David Tseng, 2012/03/06 23:49:05]

Could you also include "role=", and perhaps we should have a cross platform
template and use vswprintf in the platform implementations.

[dmazzoni, 2012/03/08 07:10:37]

Are you okay to try it without role? I tried adding role but the resulting file
is less readable, at least visually. I like that the very first thing on each
line is the role, it makes it much easier to skim a hierarchy and find a line
you're looking for.

If you still don't like it after we've added more tests, I'm fine to add role=
later, or alternatively try some other format like xml or json.

I don't think we should strive to have a strict cross-platform template, because
remember there are several fields that will only apply to either mac or win, so
we should allow them to diverge as necessary. Let's just have them use similar
syntax.

+       prefix,
+       [cocoa_node role],
+       [cocoa_node subrole],
+       [cocoa_node title],
+       [cocoa_node value]];
   std::string tempVal = [dump cStringUsingEncoding:NSUTF8StringEncoding];
 
   return UTF8ToUTF16(tempVal);
 }
 
 const FilePath::StringType DumpAccessibilityTreeHelper::GetActualFileSuffix()
     const {
   return FILE_PATH_LITERAL("-actual-mac.txt");
 }
 
 const FilePath::StringType DumpAccessibilityTreeHelper::GetExpectedFileSuffix()
     const {
   return FILE_PATH_LITERAL("-expected-mac.txt");
 }
-
-const string16 DumpAccessibilityTreeHelper::GetLineEnding() const {
-  return UTF8ToUTF16("\n");
-}