Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 9616038: Add example extension using Font Settings API. (Closed)

Created:
8 years, 9 months ago by falken
Modified:
8 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, jungshik at Google
Visibility:
Public.

Description

Add example extension using Font Settings API. BUG=114148 TEST=manually used extension Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, --3 lines) Patch
A chrome/common/extensions/docs/examples/api/fontSettings.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/fontSettings/fonts128.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/fontSettings/fonts16.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/fontSettings/manifest.json View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/fontSettings/popup.html View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/fontSettings/popup.js View 1 chunk +118 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
falken
Matt, can you please review?
8 years, 9 months ago (2012-03-06 23:41:05 UTC) #1
Matt Perry
lgtm
8 years, 9 months ago (2012-03-07 00:06:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/9616038/1
8 years, 9 months ago (2012-03-07 00:17:52 UTC) #3
commit-bot: I haz the power
Change committed as 125293
8 years, 9 months ago (2012-03-07 02:14:13 UTC) #4
mattm
On 2012/03/07 02:14:13, I haz the power (commit-bot) wrote: > Change committed as 125293 Hi ...
8 years, 9 months ago (2012-03-15 01:20:40 UTC) #5
falken
On 2012/03/15 01:20:40, mattm wrote: > On 2012/03/07 02:14:13, I haz the power (commit-bot) wrote: ...
8 years, 9 months ago (2012-03-15 01:30:28 UTC) #6
falken
8 years, 9 months ago (2012-03-15 07:50:21 UTC) #7
On 2012/03/15 01:30:28, falken wrote:
> On 2012/03/15 01:20:40, mattm wrote:
> > On 2012/03/07 02:14:13, I haz the power (commit-bot) wrote:
> > > Change committed as 125293
> > 
> > Hi there,
> > 
> > Since this was commited with CQ, all the binary files are empty.
> > 
> > I noticed because chrome/common/extensions/docs/build/build.py fails now
with
> > the error:
> > 
> > Exception: File at
> >
>
/y/src/chromium/src/chrome/common/extensions/docs/examples/api/fontSettings.zip
> > is not a zip file: File is not a zip file
> 
> Ah, I didn't realize the CQ can't commit binary files. I had noticed the empty
> zip file also and tried to fix it as part of
> http://codereview.chromium.org/9689054/ which won't work since it's also in
CQ.
> Since it's already in CQ, I'll manually commit the zip after it lands.

It should be fixed now in
https://src.chromium.org/viewvc/chrome?view=rev&revision=126853
Sorry for the trouble.

Powered by Google App Engine
This is Rietveld 408576698