Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 9602026: [Sync] Remove dependencies on BrowserThread from sync (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), pam+watch_chromium.org, akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Remove dependencies on BrowserThread from sync In all cases, we can just use plain threads. BUG=113723 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -47 lines) Patch
M chrome/browser/sync/notifier/invalidation_notifier_unittest.cc View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+zea for review
8 years, 9 months ago (2012-03-05 21:42:10 UTC) #1
Nicolas Zea
lgtm
8 years, 9 months ago (2012-03-06 02:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9602026/1
8 years, 9 months ago (2012-03-06 02:21:39 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-06 04:31:09 UTC) #4
Change committed as 125108

Powered by Google App Engine
This is Rietveld 408576698