Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc

Issue 9602026: [Sync] Remove dependencies on BrowserThread from sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/notifier/sync_notifier_factory.h" 5 #include "chrome/browser/sync/notifier/sync_notifier_factory.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/memory/weak_ptr.h" 11 #include "base/memory/weak_ptr.h"
12 #include "base/message_loop.h" 12 #include "base/message_loop.h"
13 #include "base/threading/thread.h" 13 #include "base/threading/thread.h"
14 #include "chrome/browser/sync/notifier/invalidation_version_tracker.h" 14 #include "chrome/browser/sync/notifier/invalidation_version_tracker.h"
15 #include "chrome/browser/sync/notifier/mock_sync_notifier_observer.h" 15 #include "chrome/browser/sync/notifier/mock_sync_notifier_observer.h"
16 #include "chrome/browser/sync/notifier/sync_notifier.h" 16 #include "chrome/browser/sync/notifier/sync_notifier.h"
17 #include "chrome/browser/sync/syncable/model_type.h" 17 #include "chrome/browser/sync/syncable/model_type.h"
18 #include "chrome/browser/sync/syncable/model_type_payload_map.h" 18 #include "chrome/browser/sync/syncable/model_type_payload_map.h"
19 #include "chrome/common/chrome_switches.h" 19 #include "chrome/common/chrome_switches.h"
20 #include "content/test/test_browser_thread.h"
21 #include "net/url_request/url_request_test_util.h" 20 #include "net/url_request/url_request_test_util.h"
22 #include "testing/gmock/include/gmock/gmock.h" 21 #include "testing/gmock/include/gmock/gmock.h"
23 #include "testing/gtest/include/gtest/gtest.h" 22 #include "testing/gtest/include/gtest/gtest.h"
24 23
25 namespace sync_notifier { 24 namespace sync_notifier {
26 namespace { 25 namespace {
27 26
28 using ::testing::Mock; 27 using ::testing::Mock;
29 using ::testing::NiceMock; 28 using ::testing::NiceMock;
30 using ::testing::StrictMock; 29 using ::testing::StrictMock;
31 using content::BrowserThread;
32 30
33 class SyncNotifierFactoryTest : public testing::Test { 31 class SyncNotifierFactoryTest : public testing::Test {
34 protected: 32 protected:
35 SyncNotifierFactoryTest() 33 SyncNotifierFactoryTest()
36 : ui_thread_(BrowserThread::UI, &message_loop_), 34 : command_line_(CommandLine::NO_PROGRAM) {}
37 io_thread_(BrowserThread::IO, &message_loop_),
38 command_line_(CommandLine::NO_PROGRAM) {}
39 virtual ~SyncNotifierFactoryTest() {} 35 virtual ~SyncNotifierFactoryTest() {}
40 36
41 virtual void SetUp() OVERRIDE { 37 virtual void SetUp() OVERRIDE {
42 request_context_getter_ =
43 new TestURLRequestContextGetter(
44 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO));
45 factory_.reset(new SyncNotifierFactory( 38 factory_.reset(new SyncNotifierFactory(
46 "fake_client_info", 39 "fake_client_info",
47 request_context_getter_, 40 new TestURLRequestContextGetter(message_loop_.message_loop_proxy()),
48 base::WeakPtr<sync_notifier::InvalidationVersionTracker>(), 41 base::WeakPtr<sync_notifier::InvalidationVersionTracker>(),
49 command_line_)); 42 command_line_));
50 message_loop_.RunAllPending(); 43 message_loop_.RunAllPending();
51 } 44 }
52 45
53 virtual void TearDown() OVERRIDE { 46 virtual void TearDown() OVERRIDE {
54 Mock::VerifyAndClearExpectations(&mock_observer_); 47 Mock::VerifyAndClearExpectations(&mock_observer_);
55 request_context_getter_ = NULL;
56 message_loop_.RunAllPending(); 48 message_loop_.RunAllPending();
57 command_line_ = CommandLine(CommandLine::NO_PROGRAM); 49 command_line_ = CommandLine(CommandLine::NO_PROGRAM);
58 } 50 }
59 51
60 MessageLoop message_loop_; 52 MessageLoop message_loop_;
61 content::TestBrowserThread ui_thread_;
62 content::TestBrowserThread io_thread_;
63 scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
64 StrictMock<MockSyncNotifierObserver> mock_observer_; 53 StrictMock<MockSyncNotifierObserver> mock_observer_;
65 scoped_ptr<SyncNotifierFactory> factory_; 54 scoped_ptr<SyncNotifierFactory> factory_;
66 CommandLine command_line_; 55 CommandLine command_line_;
67 }; 56 };
68 57
69 // Test basic creation of a NonBlockingInvalidationNotifier. 58 // Test basic creation of a NonBlockingInvalidationNotifier.
70 TEST_F(SyncNotifierFactoryTest, Basic) { 59 TEST_F(SyncNotifierFactoryTest, Basic) {
71 scoped_ptr<SyncNotifier> notifier(factory_->CreateSyncNotifier()); 60 scoped_ptr<SyncNotifier> notifier(factory_->CreateSyncNotifier());
72 ASSERT_TRUE(notifier.get()); 61 ASSERT_TRUE(notifier.get());
73 notifier->AddObserver(&mock_observer_); 62 notifier->AddObserver(&mock_observer_);
74 notifier->RemoveObserver(&mock_observer_); 63 notifier->RemoveObserver(&mock_observer_);
75 } 64 }
76 65
77 // Test basic creation of a P2PNotifier. 66 // Test basic creation of a P2PNotifier.
78 TEST_F(SyncNotifierFactoryTest, Basic_P2P) { 67 TEST_F(SyncNotifierFactoryTest, Basic_P2P) {
79 command_line_.AppendSwitchASCII(switches::kSyncNotificationMethod, "p2p"); 68 command_line_.AppendSwitchASCII(switches::kSyncNotificationMethod, "p2p");
80 scoped_ptr<SyncNotifier> notifier(factory_->CreateSyncNotifier()); 69 scoped_ptr<SyncNotifier> notifier(factory_->CreateSyncNotifier());
81 ASSERT_TRUE(notifier.get()); 70 ASSERT_TRUE(notifier.get());
82 notifier->AddObserver(&mock_observer_); 71 notifier->AddObserver(&mock_observer_);
83 notifier->RemoveObserver(&mock_observer_); 72 notifier->RemoveObserver(&mock_observer_);
84 } 73 }
85 74
86 } // namespace 75 } // namespace
87 } // namespace sync_notifier 76 } // namespace sync_notifier
OLDNEW
« no previous file with comments | « chrome/browser/sync/notifier/sync_notifier_factory.cc ('k') | chrome/browser/sync/tools/sync_listen_notifications.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698