Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 9601002: Simplify MSVCRT silent abort by raising SIGABRT directly (Closed)

Created:
8 years, 9 months ago by Net147
Modified:
8 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Simplify MSVCRT silent abort by raising SIGABRT directly Contributed by net147@gmail.com BUGS= TEST=

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/platform-win32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/win32-headers.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Net147
8 years, 9 months ago (2012-03-04 00:46:46 UTC) #1
Yang
On 2012/03/04 00:46:46, Net147 wrote: I'm not totally familiar with how MSVCRT handles SIGABRT, but ...
8 years, 9 months ago (2012-03-04 10:36:31 UTC) #2
Net147
The calls to _set_abort_behavior already prevent the abort message from being printed and crash dialog ...
8 years, 9 months ago (2012-03-04 10:50:34 UTC) #3
Net147
8 years, 9 months ago (2012-03-05 09:42:29 UTC) #4
Any update on this?

Powered by Google App Engine
This is Rietveld 408576698