Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: src/platform-win32.cc

Issue 9601002: Simplify MSVCRT silent abort by raising SIGABRT directly (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/win32-headers.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 924 matching lines...) Expand 10 before | Expand all | Expand 10 after
935 } 935 }
936 936
937 937
938 void OS::Sleep(int milliseconds) { 938 void OS::Sleep(int milliseconds) {
939 ::Sleep(milliseconds); 939 ::Sleep(milliseconds);
940 } 940 }
941 941
942 942
943 void OS::Abort() { 943 void OS::Abort() {
944 if (!IsDebuggerPresent()) { 944 if (!IsDebuggerPresent()) {
945 #ifdef _MSC_VER
946 // Make the MSVCRT do a silent abort. 945 // Make the MSVCRT do a silent abort.
947 _set_abort_behavior(0, _WRITE_ABORT_MSG); 946 raise(SIGABRT);
948 _set_abort_behavior(0, _CALL_REPORTFAULT);
949 #endif // _MSC_VER
950 abort();
951 } else { 947 } else {
952 DebugBreak(); 948 DebugBreak();
953 } 949 }
954 } 950 }
955 951
956 952
957 void OS::DebugBreak() { 953 void OS::DebugBreak() {
958 #ifdef _MSC_VER 954 #ifdef _MSC_VER
959 __debugbreak(); 955 __debugbreak();
960 #else 956 #else
(...skipping 1112 matching lines...) Expand 10 before | Expand all | Expand 10 after
2073 2069
2074 2070
2075 void Sampler::Stop() { 2071 void Sampler::Stop() {
2076 ASSERT(IsActive()); 2072 ASSERT(IsActive());
2077 SamplerThread::RemoveActiveSampler(this); 2073 SamplerThread::RemoveActiveSampler(this);
2078 SetActive(false); 2074 SetActive(false);
2079 } 2075 }
2080 2076
2081 2077
2082 } } // namespace v8::internal 2078 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/win32-headers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698