JSONWriter cleanup: integrate pretty print into write options.

JSONWriter cleanup: integrate pretty print into write options.

BUG=
TEST=base_unittests

TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127080

[Eric Dingle, 2012-03-07 23:59:46]

This is just a clean up change. The API change occurs in src/base/json_writer.*.
The rest is fallout.

[Eric Dingle, 2012-03-12 15:41:22]

Ping.

[darin (slow to review), 2012-03-12 17:53:18]

base/ changes LGTM

sorry for the delayed response.

[darin (slow to review), 2012-03-12 17:58:09]

LGTM for all.

[willchan no longer on Chromium, 2012-03-12 18:00:23]

net/ LGTM

On Mon, Mar 12, 2012 at 10:58 AM, <darin@chromium.org> wrote:

> LGTM for all.
>
>
http://codereview.chromium.**org/9590002/<http://codereview.chromium.org/9590...
>

[commit-bot: I haz the power, 2012-03-12 20:28:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/28002

[commit-bot: I haz the power, 2012-03-12 20:28:44]

Can't apply patch for file base/json/json_string_value_serializer.cc.
While running patch -p1 --forward --force;
patching file base/json/json_string_value_serializer.cc
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file
base/json/json_string_value_serializer.cc.rej

[commit-bot: I haz the power, 2012-03-12 20:50:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/33001

[commit-bot: I haz the power, 2012-03-12 20:51:12]

Can't apply patch for file base/json/json_string_value_serializer.cc.
While running patch -p1 --forward --force;
patching file base/json/json_string_value_serializer.cc
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file
base/json/json_string_value_serializer.cc.rej

[commit-bot: I haz the power, 2012-03-12 21:42:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/36004

[commit-bot: I haz the power, 2012-03-12 21:42:38]

Can't apply patch for file base/json/json_string_value_serializer.cc.
While running patch -p1 --forward --force;
patching file base/json/json_string_value_serializer.cc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
base/json/json_string_value_serializer.cc.rej

[commit-bot: I haz the power, 2012-03-14 20:59:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/43005

[commit-bot: I haz the power, 2012-03-14 21:00:12]

Presubmit check for 9590002-43005 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui/print_preview
    remoting
    chrome/browser/chromeos/cros
    chrome/browser/policy
    chrome/browser/sync
    chrome/browser/bookmarks
    chrome/browser/ui/webui
    chrome/browser/printing/cloud_print
    chrome/browser/history

Presubmit checks took 10.5s to calculate.

[commit-bot: I haz the power, 2012-03-14 21:08:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/43005

[commit-bot: I haz the power, 2012-03-14 22:10:51]

Try job failure for 9590002-43005 (retry) on android for steps "Compile, build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-03-15 20:16:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/46006

[commit-bot: I haz the power, 2012-03-15 21:28:41]

Can't apply patch for file chrome/browser/chromeos/gdata/gdata_file_system.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/gdata/gdata_file_system.cc
Hunk #1 FAILED at 1346.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/chromeos/gdata/gdata_file_system.cc.rej

[commit-bot: I haz the power, 2012-03-15 22:45:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9590002/46010

[commit-bot: I haz the power, 2012-03-16 02:00:12]

Change committed as 127080