chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc - Issue 9590002: JSONWriter cleanup: integrate pretty print into write options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc

Issue 9590002: JSONWriter cleanup: integrate pretty print into write options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge conflict 7. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/settings/settings_quota_unittest.cc ('k') | chrome/browser/extensions/settings/settings_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc

diff --git a/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc b/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc

index d0f5ace8baf2897b9a1a0e7fb652325c93334ef1..f5eb742a5bb68688aed9e69518a583eed61ef042 100644

--- a/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc

+++ b/chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc

@@ -35,7 +35,7 @@ void Allocate(

// TODO(kalman): This is duplicating work that the leveldb delegate

// implementation is about to do, and it would be nice to avoid this.

std::string value_as_json;

- base::JSONWriter::Write(&value, false, &value_as_json);

+ base::JSONWriter::Write(&value, &value_as_json);

size_t new_size = key.size() + value_as_json.size();

size_t existing_size = (*used_per_setting)[key];