Handle closing of HTTP client and server

Handle closing of HTTP client and server

For the server keep track of the state of the connection and close the
socket when it is closed by the client. The client might close the
connection both when processing a request and while the connection is
an idle keep alive connection.

For the client keep track of the active connections as well as the
idle keep alive connections. When the client is closed make sure to
close all connections.

R=ajohnsen@google.com

BUG=none
TEST=tests/standalone/src/io/HttpShutdownTest.dart

Committed: https://code.google.com/p/dart/source/detail?r=4932

[Anders Johnsen, 2012-03-02 13:48:10]

LGTM, thank you! :)

https://chromiumcodereview.appspot.com/9589001/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9589001/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:962: void _onClosed() {
This is a lot easier to read. Thank you!

https://chromiumcodereview.appspot.com/9589001/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:1089: // TODO(ajohnsen): Use Set once Socket is
Hashable.
Now that Socket is hashable, could you use a Set here?

https://chromiumcodereview.appspot.com/9589001/diff/1/tests/standalone/src/io...
File tests/standalone/src/io/HttpShutdownTest.dart (right):

https://chromiumcodereview.appspot.com/9589001/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpShutdownTest.dart:56: client.shutdown();
With no keepAlive, maybe remove this line?

https://chromiumcodereview.appspot.com/9589001/diff/1/tests/standalone/src/io...
tests/standalone/src/io/HttpShutdownTest.dart:80: request.keepAlive = false;
Ditto.

[Anders Johnsen, 2012-03-03 10:10:21]

Just applied it locally, and it fixes all my issues. Thank you!

[Søren Gjesse, 2012-03-05 07:03:41]

http://codereview.chromium.org/9589001/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/9589001/diff/1/runtime/bin/http_impl.dart#newc...
runtime/bin/http_impl.dart:1089: // TODO(ajohnsen): Use Set once Socket is
Hashable.
On 2012/03/02 13:48:10, ajohnsen wrote:
> Now that Socket is hashable, could you use a Set here?

Done.

http://codereview.chromium.org/9589001/diff/1/tests/standalone/src/io/HttpShu...
File tests/standalone/src/io/HttpShutdownTest.dart (right):

http://codereview.chromium.org/9589001/diff/1/tests/standalone/src/io/HttpShu...
tests/standalone/src/io/HttpShutdownTest.dart:56: client.shutdown();
On 2012/03/02 13:48:10, ajohnsen wrote:
> With no keepAlive, maybe remove this line?

I think it is a bug in the test setting keep alive to false. Changed that to
true and kept the shutdown.

http://codereview.chromium.org/9589001/diff/1/tests/standalone/src/io/HttpShu...
tests/standalone/src/io/HttpShutdownTest.dart:80: request.keepAlive = false;
On 2012/03/02 13:48:10, ajohnsen wrote:
> Ditto.

Ditto.