Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 9585021: Add short version of incognito NTP for mobile. (Closed)

Created:
8 years, 9 months ago by nyquist
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add short version of incognito NTP for mobile. This adds a short version of the incognito NTP to be used by smaller mobile devices. It also changes to singular 'mobile device' for the current Android incognito NTP. BUG=114046 TEST=Verify that strings show up correctly in Android build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125042

Patch Set 1 #

Patch Set 2 : Added missing mobile prefix for description #

Patch Set 3 : Added Mobile:-prefix to description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nyquist
8 years, 9 months ago (2012-03-02 19:50:31 UTC) #1
sky
Don't you need to address the concerns Mark raised in the last patch about different ...
8 years, 9 months ago (2012-03-02 20:49:21 UTC) #2
nyquist
Addressed comment about Mobile:. PTAL.
8 years, 9 months ago (2012-03-05 18:19:52 UTC) #3
sky
LGTM
8 years, 9 months ago (2012-03-05 22:08:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/9585021/5001
8 years, 9 months ago (2012-03-05 22:08:41 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-06 00:19:36 UTC) #6
Change committed as 125042

Powered by Google App Engine
This is Rietveld 408576698