Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 9584014: Remove env() getter from JavaRef<> (Closed)

Created:
8 years, 9 months ago by joth
Modified:
8 years, 9 months ago
Reviewers:
bulach, Steve Block
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove env() getter from JavaRef<> Due to threadsafety ambiguity, it's not generally safe to call env() on a random Ref you've been passed, so this removes the temptation. The useful LocalRef optimizations are retained though, just in that sub-class. (upstreaming CL, cherrypicked cleanly) BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128204

Patch Set 1 #

Patch Set 2 : re-applied downstream patch after it was re-worked #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -60 lines) Patch
M base/android/jni_string.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/android/scoped_java_ref.h View 1 6 chunks +40 lines, -22 lines 0 comments Download
M base/android/scoped_java_ref.cc View 1 1 chunk +28 lines, -21 lines 0 comments Download
M content/browser/renderer_host/java/java_bound_object.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/java/java_bound_object.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M content/browser/renderer_host/java/java_method.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
joth
8 years, 9 months ago (2012-03-02 15:29:57 UTC) #1
bulach
lgtm thanks!
8 years, 9 months ago (2012-03-02 15:41:03 UTC) #2
joth
+steveblock for renderer_host/java OWNER
8 years, 9 months ago (2012-03-02 15:44:13 UTC) #3
Steve Block
lgtm
8 years, 9 months ago (2012-03-02 16:03:01 UTC) #4
joth
PTAL- Re-uploaded after re-landing the patch downstream, so this is a direct copy of the ...
8 years, 9 months ago (2012-03-21 19:05:03 UTC) #5
Steve Block
lgtm
8 years, 9 months ago (2012-03-21 19:42:04 UTC) #6
bulach
lgtm, thanks!
8 years, 9 months ago (2012-03-21 19:55:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/9584014/4001
8 years, 9 months ago (2012-03-22 12:46:54 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 13:52:59 UTC) #9
Change committed as 128204

Powered by Google App Engine
This is Rietveld 408576698