content/browser/renderer_host/java/java_bound_object.h - Issue 9584014: Remove env() getter from JavaRef<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/java/java_bound_object.h

Issue 9584014: Remove env() getter from JavaRef<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-applied downstream patch after it was re-worked Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/java/java_bound_object.h

diff --git a/content/browser/renderer_host/java/java_bound_object.h b/content/browser/renderer_host/java/java_bound_object.h

index 61a1dfbeb6d037056f1452b5c6d20c8fe5d06138..992929b74cd3c150084e81446b4f7099f6c16130 100644

--- a/content/browser/renderer_host/java/java_bound_object.h

+++ b/content/browser/renderer_host/java/java_bound_object.h

@@ -44,10 +44,9 @@ class JavaBoundObject {

void EnsureMethodsAreSetUp() const;

- // Global ref to the underlying Java object. We use a naked jobject, rather

- // than a ScopedJavaGlobalRef, as the global ref will be added and dropped on

- // different threads.

- jobject java_object_;

+ // The global ref to the underlying Java object that this JavaBoundObject

+ // instance represents.

+ base::android::ScopedJavaGlobalRef<jobject> java_object_;

// Map of public methods, from method name to Method instance. Multiple

// entries will be present for overloaded methods. Note that we can't use