Issue 9570037: Double clicking the resize handle should expand window along that axis.

Issue 9570037: Double clicking the resize handle should expand window along that axis. (Closed)

Created:
8 years, 9 months ago by Ben Goodger (Google)

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Double clicking the resize handle should expand window along that axis. http://crbug.com/116073 TEST=see unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124597

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -6 lines)			Patch
M	ash/ash.gyp	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.h	View	1 2	2 chunks	+9 lines, -2 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.cc	View	1 2	4 chunks	+58 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/workspace_event_filter_unittest.cc	View	1 2	1 chunk	+101 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/test/test_window_delegate.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/9570037/diff/9/ash/wm/workspace/workspace_event_filter.cc File ash/wm/workspace/workspace_event_filter.cc (right): http://codereview.chromium.org/9570037/diff/9/ash/wm/workspace/workspace_event_filter.cc#newcode33 ash/wm/workspace/workspace_event_filter.cc:33: window->SetProperty(aura::client::kRestoreBoundsKey, You'll want to clear first, otherwise this ...

8 years, 9 months ago (2012-03-01 23:23:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/9570037/6002

8 years, 9 months ago (2012-03-02 00:52:58 UTC) #3

Change committed as 124597

Expand Messages | Collapse Messages