Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: ash/wm/workspace/workspace_event_filter_unittest.cc

Issue 9570037: Double clicking the resize handle should expand window along that axis. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_event_filter.cc ('k') | ash/wm/workspace/workspace_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_event_filter_unittest.cc
===================================================================
--- ash/wm/workspace/workspace_event_filter_unittest.cc (revision 0)
+++ ash/wm/workspace/workspace_event_filter_unittest.cc (revision 0)
@@ -0,0 +1,101 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/wm/workspace/workspace_event_filter.h"
+
+#include "ash/shell.h"
+#include "ash/test/ash_test_base.h"
+#include "ash/wm/window_util.h"
+#include "ash/wm/workspace_controller.h"
+#include "ash/wm/workspace/workspace_manager.h"
+#include "ui/aura/test/event_generator.h"
+#include "ui/aura/test/test_window_delegate.h"
+#include "ui/aura/window.h"
+#include "ui/base/hit_test.h"
+#include "ui/gfx/screen.h"
+
+namespace ash {
+namespace internal {
+
+class WorkspaceEventFilterTest : public test::AshTestBase {
+ public:
+ WorkspaceEventFilterTest() {}
+ virtual ~WorkspaceEventFilterTest() {}
+
+ protected:
+ aura::Window* CreateTestWindow(aura::WindowDelegate* delegate,
+ const gfx::Rect& bounds) {
+ aura::Window* window = new aura::Window(delegate);
+ window->SetType(aura::client::WINDOW_TYPE_NORMAL);
+ window->Init(ui::Layer::LAYER_TEXTURED);
+ window->SetParent(NULL);
+ window->SetBounds(bounds);
+ window->Show();
+ return window;
+ }
+
+ private:
+ // Overridden from test::AshTestBase:
+ virtual bool GetOverrideWindowMode(Shell::WindowMode* window_mode) OVERRIDE {
+ *window_mode = Shell::MODE_MANAGED;
+ return true;
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(WorkspaceEventFilterTest);
+};
+
+TEST_F(WorkspaceEventFilterTest, DoubleClickSingleAxisResizeEdge) {
+ Shell::TestApi shell_test(Shell::GetInstance());
+ WorkspaceManager* manager =
+ shell_test.workspace_controller()->workspace_manager();
+ manager->set_grid_size(0);
+
+ // Double clicking the vertical resize edge of a window should maximize it
+ // vertically.
+ gfx::Rect restored_bounds(10, 10, 50, 50);
+ aura::test::TestWindowDelegate wd;
+ scoped_ptr<aura::Window> window(CreateTestWindow(&wd, restored_bounds));
+
+ gfx::Rect work_area =
+ gfx::Screen::GetMonitorWorkAreaNearestWindow(window.get());
+
+ aura::test::EventGenerator generator(Shell::GetRootWindow(), window.get());
+
+ // Double-click the top resize edge.
+ wd.set_window_component(HTTOP);
+ generator.DoubleClickLeftButton();
+ EXPECT_EQ(work_area.y(), window->bounds().y());
+ EXPECT_EQ(work_area.height(), window->bounds().height());
+ // Single-axis maximization is not considered real maximization.
+ EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
+
+ // Restore.
+ generator.DoubleClickLeftButton();
+ EXPECT_EQ(restored_bounds.y(), window->bounds().y());
+ EXPECT_EQ(restored_bounds.height(), window->bounds().height());
+
+ // Double-click the top resize edge again to maximize vertically, then double
+ // click the caption to maximize in all directions.
+ generator.DoubleClickLeftButton();
+ wd.set_window_component(HTCAPTION);
+ generator.DoubleClickLeftButton();
+ EXPECT_TRUE(wm::IsWindowMaximized(window.get()));
+
+ // Double clicking the caption again should completely restore the window.
+ generator.DoubleClickLeftButton();
+ EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
+ EXPECT_EQ(restored_bounds.y(), window->bounds().y());
+ EXPECT_EQ(restored_bounds.height(), window->bounds().height());
+
+ // Double clicking the left resize edge should maximize horizontally.
+ wd.set_window_component(HTLEFT);
+ generator.DoubleClickLeftButton();
+ EXPECT_EQ(work_area.x(), window->bounds().x());
+ EXPECT_EQ(work_area.width(), window->bounds().width());
+ // Single-axis maximization is not considered real maximization.
+ EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
+}
+
+} // namespace internal
+} // namespace ash
Property changes on: ash\wm\workspace\workspace_event_filter_unittest.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « ash/wm/workspace/workspace_event_filter.cc ('k') | ash/wm/workspace/workspace_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698