Issue 9569029: Improved resource management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9569029: Improved resource management (Closed)

Created:
8 years, 9 months ago by Vitaly Buka (NO REVIEWS)

Modified:
8 years, 9 months ago

Reviewers:
gene

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improved resource management by using ScopedPrinterHandle. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124755

Patch Set 1 : Review #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -54 lines)			Patch
M	chrome/service/cloud_print/print_system_win.cc	View	8 chunks	+29 lines, -27 lines	0 comments	Download
M	printing/backend/print_backend_win.cc	View	3 chunks	+8 lines, -15 lines	0 comments	Download
M	printing/printing_context_win.cc	View	6 chunks	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9569029/4002

8 years, 9 months ago (2012-03-02 18:49:36 UTC) #3

commit-bot: I haz the power

Presubmit check for 9569029-4002 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 9 months ago (2012-03-02 18:49:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9569029/4002

8 years, 9 months ago (2012-03-02 18:50:48 UTC) #5

Change committed as 124755

Expand Messages | Collapse Messages