Improved resource management

printing/printing_context_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printing_context_win.h"
 
 #include <winspool.h>
 
 #include <algorithm>
 
 #include "base/i18n/file_util_icu.h"
 #include "base/i18n/time_formatting.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "printing/backend/win_helper.h"
 #include "printing/print_job_constants.h"
 #include "printing/print_settings_initializer_win.h"
 #include "printing/printed_document.h"
 #include "printing/units.h"
 #include "skia/ext/platform_device.h"
 
 using base::Time;
 
 namespace {
 
@@ skipping 347 matching lines @@
       }
     }
     paper_rect.SetRect(0, 0, paper_size.width(), paper_size.height());
     settings_.SetPrinterPrintableArea(paper_size, paper_rect, kPDFDpi);
     settings_.set_dpi(kPDFDpi);
     settings_.SetOrientation(landscape);
     settings_.ranges = ranges;
     return OK;
   }
 
-  HANDLE printer;
+  ScopedPrinterHandle printer;
   LPWSTR device_name_wide = const_cast<wchar_t*>(device_name.c_str());
-  if (!OpenPrinter(device_name_wide, &printer, NULL))
+  if (!OpenPrinter(device_name_wide, printer.Receive(), NULL))
     return OnError();
 
   // Make printer changes local to Chrome.
   // See MSDN documentation regarding DocumentProperties.
   scoped_array<uint8> buffer;
   DEVMODE* dev_mode = NULL;
   LONG buffer_size = DocumentProperties(NULL, printer, device_name_wide,
                                         NULL, NULL, 0);
   if (buffer_size > 0) {
     buffer.reset(new uint8[buffer_size]);
     memset(buffer.get(), 0, buffer_size);
     if (DocumentProperties(NULL, printer, device_name_wide,
                            reinterpret_cast<PDEVMODE>(buffer.get()), NULL,
                            DM_OUT_BUFFER) == IDOK) {
       dev_mode = reinterpret_cast<PDEVMODE>(buffer.get());
     }
   }
   if (dev_mode == NULL) {
     buffer.reset();
-    ClosePrinter(printer);
     return OnError();
   }
 
   if (color == GRAY)
     dev_mode->dmColor = DMCOLOR_MONOCHROME;
   else
     dev_mode->dmColor = DMCOLOR_COLOR;
 
   dev_mode->dmCopies = std::max(copies, 1);
   if (dev_mode->dmCopies > 1)  // do not change collate unless multiple copies
     dev_mode->dmCollate = collate ? DMCOLLATE_TRUE : DMCOLLATE_FALSE;
   switch (duplex_mode) {
     case LONG_EDGE:
       dev_mode->dmDuplex = DMDUP_VERTICAL;
       break;
     case SHORT_EDGE:
       dev_mode->dmDuplex = DMDUP_HORIZONTAL;
       break;
     case SIMPLEX:
       dev_mode->dmDuplex = DMDUP_SIMPLEX;
       break;
     default:  // UNKNOWN_DUPLEX_MODE
       break;
   }
   dev_mode->dmOrientation = landscape ? DMORIENT_LANDSCAPE : DMORIENT_PORTRAIT;
 
   // Update data using DocumentProperties.
   if (DocumentProperties(NULL, printer, device_name_wide, dev_mode, dev_mode,
                          DM_IN_BUFFER | DM_OUT_BUFFER) != IDOK) {
-    ClosePrinter(printer);
     return OnError();
   }
 
   // Set printer then refresh printer settings.
   if (!AllocateContext(device_name, dev_mode, &context_)) {
-    ClosePrinter(printer);
     return OnError();
   }
   PrintSettingsInitializerWin::InitPrintSettings(context_, *dev_mode,
                                                  ranges, device_name,
                                                  false, &settings_);
-  ClosePrinter(printer);
   return OK;
 }
 
 PrintingContext::Result PrintingContextWin::InitWithSettings(
     const PrintSettings& settings) {
   DCHECK(!in_print_job_);
 
   settings_ = settings;
 
   // TODO(maruel): settings_.ToDEVMODE()
-  HANDLE printer;
+  ScopedPrinterHandle printer;
   if (!OpenPrinter(const_cast<wchar_t*>(settings_.device_name().c_str()),
-                   &printer,
-                   NULL))
+                   printer.Receive(), NULL))
     return FAILED;
 
   Result status = OK;
 
   if (!GetPrinterSettings(printer, settings_.device_name()))
     status = FAILED;
 
-  // Close the printer after retrieving the context.
-  ClosePrinter(printer);
-
   if (status != OK)
     ResetSettings();
   return status;
 }
 
 PrintingContext::Result PrintingContextWin::NewDocument(
     const string16& document_name) {
   DCHECK(!in_print_job_);
   if (!context_)
     return OnError();
@@ skipping 321 matching lines @@
   if (buf_size) {
     buffer->reset(new uint8[buf_size]);
     memset(buffer->get(), 0, buf_size);
     if (!GetPrinter(printer, level, buffer->get(), buf_size, &buf_size)) {
       buffer->reset();
     }
   }
 }
 
 }  // namespace printing