Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 9568039: Added guard to not set scrollTop if it hasn't changed. Surprisingly, this speeds up the list.redraw… (Closed)

Created:
8 years, 9 months ago by Kevin Greer
Modified:
8 years, 9 months ago
Reviewers:
yoshiki, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Added guard to not set scrollTop if it hasn't changed. Surprisingly, this speeds up the list.redraw() method by 19X. BUG=62854 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124700

Patch Set 1 #

Patch Set 2 : Removed setting of scrollTop. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/resources/shared/js/cr/ui/list.js View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kevin Greer
Please review this very short CL.
8 years, 9 months ago (2012-03-01 22:07:27 UTC) #1
Kevin Greer
Actually, due to changes in the list behaviour, the scrollTop variable is no longer updated, ...
8 years, 9 months ago (2012-03-02 15:15:01 UTC) #2
Evan Stade
ok, lgtm
8 years, 9 months ago (2012-03-02 17:21:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kgr@chromium.org/9568039/3001
8 years, 9 months ago (2012-03-02 17:29:19 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 19:02:16 UTC) #5
Change committed as 124700

Powered by Google App Engine
This is Rietveld 408576698