chrome/browser/resources/shared/js/cr/ui/list.js - Issue 9568039: Added guard to not set scrollTop if it hasn't changed. Surprisingly, this speeds up the list.redraw…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/list.js

Issue 9568039: Added guard to not set scrollTop if it hasn't changed. Surprisingly, this speeds up the list.redraw… (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Removed setting of scrollTop. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/shared/js/cr/ui/list.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/list.js b/chrome/browser/resources/shared/js/cr/ui/list.js

index e2f242a6d32972fef995eb83c9822ec3385bf72e..67472a2cffb34e2c0ad88322b3701f310ae30dfb 100644

--- a/chrome/browser/resources/shared/js/cr/ui/list.js

+++ b/chrome/browser/resources/shared/js/cr/ui/list.js

@@ -1120,8 +1120,6 @@ cr.define('cr.ui', function() {

listItem = newCachedItems[y];

}

- this.scrollTop = scrollTop;

this.firstIndex_ = firstIndex;

this.lastIndex_ = lastIndex;

« no previous file with comments | « no previous file | no next file » | no next file with comments »