Issue 9567021: Preload ddraw.dll before initializing sandbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9567021: Preload ddraw.dll before initializing sandbox. (Closed)

Created:
8 years, 9 months ago by jbauman

Modified:
8 years, 9 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, dhollowa+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Preload ddraw.dll before initializing sandbox. Needed for swiftshader to work. BUG=116092 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124550

Patch Set 2 : switch to LoadLibrary #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	ui/gfx/gl/gl_implementation_win.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

lgtm https://chromiumcodereview.appspot.com/9567021/diff/1/ui/gfx/gl/gl_implementation_win.cc File ui/gfx/gl/gl_implementation_win.cc (right): https://chromiumcodereview.appspot.com/9567021/diff/1/ui/gfx/gl/gl_implementation_win.cc#newcode150 ui/gfx/gl/gl_implementation_win.cc:150: base::NativeLibrary ddraw_library = base::LoadNativeLibrary( "base::NativeLibrary ddraw_library = " ...

8 years, 9 months ago (2012-03-01 20:30:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9567021/8001

8 years, 9 months ago (2012-03-01 21:53:55 UTC) #3

Change committed as 124550

Expand Messages | Collapse Messages

Issue 9567021: Preload ddraw.dll before initializing sandbox. (Closed)

Description

Patch Set 1 #

Patch Set 2 : switch to LoadLibrary #

Messages