Fix memory leak in LaunchSelLdr.

Fix memory leak in LaunchSelLdr.

BUG=116383
TEST= none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124686

[sehr (please use chromium), 2012-03-01 19:05:48]

Please change to use scoped_ptr.

https://chromiumcodereview.appspot.com/9566008/diff/1/chrome/browser/nacl_hos...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

https://chromiumcodereview.appspot.com/9566008/diff/1/chrome/browser/nacl_hos...
chrome/browser/nacl_host/nacl_process_host.cc:395: CommandLine* cmd_line = new
CommandLine(exe_path);
It would be better if this became:
scoped_ptr<CommandLine> cmd_line(new CommandLine(exe_path));

https://chromiumcodereview.appspot.com/9566008/diff/1/chrome/browser/nacl_hos...
chrome/browser/nacl_host/nacl_process_host.cc:410: delete cmd_line;
Then we could remove this line.

https://chromiumcodereview.appspot.com/9566008/diff/1/chrome/browser/nacl_hos...
chrome/browser/nacl_host/nacl_process_host.cc:414: process_->Launch(FilePath(),
cmd_line);
This would have to be cmd_line.release()

https://chromiumcodereview.appspot.com/9566008/diff/1/chrome/browser/nacl_hos...
chrome/browser/nacl_host/nacl_process_host.cc:419: cmd_line);
As would this.

[halyavin, 2012-03-02 09:21:24]

PTAL.

http://codereview.chromium.org/9566008/diff/1/chrome/browser/nacl_host/nacl_p...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

http://codereview.chromium.org/9566008/diff/1/chrome/browser/nacl_host/nacl_p...
chrome/browser/nacl_host/nacl_process_host.cc:395: CommandLine* cmd_line = new
CommandLine(exe_path);
On 2012/03/01 19:05:48, sehr wrote:
> It would be better if this became:
> scoped_ptr<CommandLine> cmd_line(new CommandLine(exe_path));

Done.

http://codereview.chromium.org/9566008/diff/1/chrome/browser/nacl_host/nacl_p...
chrome/browser/nacl_host/nacl_process_host.cc:410: delete cmd_line;
On 2012/03/01 19:05:48, sehr wrote:
> Then we could remove this line.

Done.

http://codereview.chromium.org/9566008/diff/1/chrome/browser/nacl_host/nacl_p...
chrome/browser/nacl_host/nacl_process_host.cc:414: process_->Launch(FilePath(),
cmd_line);
On 2012/03/01 19:05:48, sehr wrote:
> This would have to be cmd_line.release()

Done.

http://codereview.chromium.org/9566008/diff/1/chrome/browser/nacl_host/nacl_p...
chrome/browser/nacl_host/nacl_process_host.cc:419: cmd_line);
On 2012/03/01 19:05:48, sehr wrote:
> As would this.

Done.

[sehr (please use chromium), 2012-03-02 16:34:59]

lgtm

[commit-bot: I haz the power, 2012-03-02 16:38:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/halyavin@google.com/9566008/6001

[commit-bot: I haz the power, 2012-03-02 18:15:53]

Change committed as 124686