Fix memory leak in LaunchSelLdr.

chrome/browser/nacl_host/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/nacl_process_host.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 374 matching lines @@
   int flags = nacl_loader_prefix.empty() ? ChildProcessHost::CHILD_ALLOW_SELF :
                                            ChildProcessHost::CHILD_NORMAL;
 #else
   int flags = ChildProcessHost::CHILD_NORMAL;
 #endif
 
   FilePath exe_path = ChildProcessHost::GetChildPath(flags);
   if (exe_path.empty())
     return false;
 
   CommandLine* cmd_line = new CommandLine(exe_path);

[sehr (please use chromium), 2012/03/01 19:05:48]

It would be better if this became:
scoped_ptr<CommandLine> cmd_line(new CommandLine(exe_path));

[halyavin, 2012/03/02 09:21:24]

Done.

   nacl::CopyNaClCommandLineArguments(cmd_line);
 
   cmd_line->AppendSwitchASCII(switches::kProcessType,
                               switches::kNaClLoaderProcess);
   cmd_line->AppendSwitchASCII(switches::kProcessChannelID, channel_id);
   if (logging::DialogsAreSuppressed())
     cmd_line->AppendSwitch(switches::kNoErrorDialogs);
 
   if (!nacl_loader_prefix.empty())
     cmd_line->PrependWrapper(nacl_loader_prefix);
 
   // On Windows we might need to start the broker process to launch a new loader
 #if defined(OS_WIN)
   if (RunningOnWOW64()) {
+    delete cmd_line;

[sehr (please use chromium), 2012/03/01 19:05:48]

Then we could remove this line.

[halyavin, 2012/03/02 09:21:24]

Done.

     return NaClBrokerService::GetInstance()->LaunchLoader(
         this, ASCIIToWide(channel_id));
   } else {
     process_->Launch(FilePath(), cmd_line);

[sehr (please use chromium), 2012/03/01 19:05:48]

This would have to be cmd_line.release()

[halyavin, 2012/03/02 09:21:24]

Done.

   }
 #elif defined(OS_POSIX)
   process_->Launch(nacl_loader_prefix.empty(),  // use_zygote
                    base::EnvironmentVector(),
                    cmd_line);

[sehr (please use chromium), 2012/03/01 19:05:48]

As would this.

[halyavin, 2012/03/02 09:21:24]

Done.

 #endif
 
   return true;
 }
 
 void NaClProcessHost::OnProcessLaunchedByBroker(base::ProcessHandle handle) {
   process_->SetHandle(handle);
   OnProcessLaunched();
 }
 
@@ skipping 298 matching lines @@
   process_->Send(new NaClProcessMsg_Start(handles_for_sel_ldr));
 #endif
 
   internal_->sockets_for_sel_ldr.clear();
 }
 
 bool NaClProcessHost::OnMessageReceived(const IPC::Message& msg) {
   NOTREACHED() << "Invalid message with type = " << msg.type();
   return false;
 }