Use a check item instead of changing its text.

Use a check item instead of changing a menu-item text.
This change changes a menu item "Ask Google for suggestions" to a check item as suggested in privacy review.

BUG=110362
TEST=browser_tests --gtest_filter=SpellingMenuObserverTest.EnableSpellingService

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124931

[Hironori Bono, 2012-03-02 05:44:46]

Greetings Brett,

Sorry for my sudden request. Would it be possible to review this UI change? (It
seems Avi has been out of office.)

Regards,

Hironori Bono

[Avi (use Gerrit), 2012-03-03 02:55:07]

lgtm with small spelling corrections

http://codereview.chromium.org/9562002/diff/5001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc (right):

http://codereview.chromium.org/9562002/diff/5001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc:259: //
integration to verify an item "Ask Google for suggesitons" is checked. (This
s/suggesitons/suggestions/

http://codereview.chromium.org/9562002/diff/5001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc:276: // item
and verity it is enabled and checked.
s/verity/verifies/

[Hironori Bono, 2012-03-05 07:13:18]

Greeting Avi,

Many thanks for your review and fixing my English. (I thought you were
out-of-office last Friday. Sorry for disturbing you.) I have applied them and
sent the updated one to commit-queue.

Regards,

Hironori Bono

http://codereview.chromium.org/9562002/diff/5001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc (right):

http://codereview.chromium.org/9562002/diff/5001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc:259: //
integration to verify an item "Ask Google for suggesitons" is checked. (This
On 2012/03/03 02:55:08, Avi wrote:
> s/suggesitons/suggestions/

Done.

http://codereview.chromium.org/9562002/diff/5001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc:276: // item
and verity it is enabled and checked.
On 2012/03/03 02:55:08, Avi wrote:
> s/verity/verifies/

Done.

[commit-bot: I haz the power, 2012-03-05 07:13:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hbono@chromium.org/9562002/10001

[commit-bot: I haz the power, 2012-03-05 08:36:23]

Try job failure for 9562002-10001 (retry) on mac_rel for step "ui_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-03-05 10:27:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hbono@chromium.org/9562002/10001

[commit-bot: I haz the power, 2012-03-05 11:56:42]

Change committed as 124931