Use a check item instead of changing its text.

chrome/browser/tab_contents/spelling_menu_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/spelling_menu_observer.h"
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/prefs/pref_service.h"
@@ skipping 89 matching lines @@
     proxy_->AddSeparator();
 
     // |spellcheck_host| can be null when the suggested word is
     // provided by Web SpellCheck API.
     SpellCheckHost* spellcheck_host =
         SpellCheckFactory::GetHostForProfile(profile);
     if (spellcheck_host && spellcheck_host->GetMetrics())
       spellcheck_host->GetMetrics()->RecordSuggestionStats(1);
   }
 
-  // If word is misspelled, give option for "Add to dictionary" and "Ask Google
-  // for suggestions". (The SpellCheckerSubMenuObserver class handles the "Ask
-  // Goole for suggestions" item so this class does not have to handle it.)
+  // If word is misspelled, give option for "Add to dictionary" and a check item
+  // "Ask Google for suggestions".
   if (!params.misspelled_word.empty()) {
     if (params.dictionary_suggestions.empty()) {
       proxy_->AddMenuItem(IDC_CONTENT_CONTEXT_NO_SPELLING_SUGGESTIONS,
           l10n_util::GetStringUTF16(
               IDS_CONTENT_CONTEXT_NO_SPELLING_SUGGESTIONS));
     }
     misspelled_word_ = params.misspelled_word;
     proxy_->AddMenuItem(IDC_SPELLCHECK_ADD_TO_DICTIONARY,
         l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_ADD_TO_DICTIONARY));
 
     integrate_spelling_service_ =
         profile->GetPrefs()->GetBoolean(prefs::kSpellCheckUseSpellingService);
-    int spelling_message = integrate_spelling_service_ ?
-        IDS_CONTENT_CONTEXT_SPELLING_STOP_ASKING_GOOGLE :
-        IDS_CONTENT_CONTEXT_SPELLING_ASK_GOOGLE;
-    proxy_->AddMenuItem(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE,
-                        l10n_util::GetStringUTF16(spelling_message));
+    proxy_->AddCheckItem(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE,
+        l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_SPELLING_ASK_GOOGLE));
 
     proxy_->AddSeparator();
   }
 }
 
 bool SpellingMenuObserver::IsCommandIdSupported(int command_id) {
   if (command_id >= IDC_SPELLCHECK_SUGGESTION_0 &&
       command_id <= IDC_SPELLCHECK_SUGGESTION_4)
     return true;
 
   switch (command_id) {
     case IDC_SPELLCHECK_ADD_TO_DICTIONARY:
     case IDC_CONTENT_CONTEXT_NO_SPELLING_SUGGESTIONS:
     case IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION:
     case IDC_CONTENT_CONTEXT_SPELLING_TOGGLE:
       return true;
 
     default:
       return false;
   }
   return false;
 }
 
+bool SpellingMenuObserver::IsCommandIdChecked(int command_id) {
+  DCHECK(IsCommandIdSupported(command_id));
+
+  if (command_id == IDC_CONTENT_CONTEXT_SPELLING_TOGGLE)
+    return integrate_spelling_service_;
+  return false;
+}
+
 bool SpellingMenuObserver::IsCommandIdEnabled(int command_id) {
   DCHECK(IsCommandIdSupported(command_id));
 
   if (command_id >= IDC_SPELLCHECK_SUGGESTION_0 &&
       command_id <= IDC_SPELLCHECK_SUGGESTION_4)
     return true;
 
   switch (command_id) {
     case IDC_SPELLCHECK_ADD_TO_DICTIONARY:
       return !misspelled_word_.empty();
@@ skipping 49 matching lines @@
       SpellCheckHost* host = SpellCheckFactory::GetHostForProfile(profile);
       if (host)
         host->AddWord(UTF16ToUTF8(misspelled_word_));
     }
 #if defined(OS_MACOSX)
     spellcheck_mac::AddWord(misspelled_word_);
 #endif
   }
 
   if (command_id == IDC_CONTENT_CONTEXT_SPELLING_TOGGLE) {
-    // When a user chooses the "Ask Google for spelling suggestions" item, we
-    // show a bubble to confirm it. On the other hand, when a user chooses the
-    // "Stop asking Google for spelling suggestions" item, we directly update
-    // the profile and stop integrating the spelling service immediately.
+    // When a user enables the "Ask Google for spelling suggestions" item, we
+    // show a bubble to confirm it. On the other hand, when a user disables this
+    // item, we directly update/ the profile and stop integrating the spelling
+    // service immediately.
     if (!integrate_spelling_service_) {
       RenderViewHost* rvh = proxy_->GetRenderViewHost();
       gfx::Rect rect = rvh->view()->GetViewBounds();
       ConfirmBubbleModel::Show(rvh->view()->GetNativeView(),
                                gfx::Point(rect.CenterPoint().x(), rect.y()),
                                new SpellingBubbleModel(proxy_->GetProfile()));
     } else {
       Profile* profile = proxy_->GetProfile();
       if (profile)
         profile->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService,
@@ skipping 44 matching lines @@
   loading_frame_ = (loading_frame_ + 1) & 3;
   string16 loading_message = loading_message_;
   for (int i = 0; i < loading_frame_; ++i)
     loading_message.push_back('.');
 
   // Update the menu item with the text. We disable this item to prevent users
   // from selecting it.
   proxy_->UpdateMenuItem(IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION, false, false,
                          loading_message);
 }