Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 9558007: Ensure that SequencedWorkerPools in tests don't outlive their tests (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Ensure that SequencedWorkerPools in tests don't outlive their tests This prevents strange races with other tests. Add an OnDestroy() method to SequencedWorkerPool::TestingObserver(). Fix a bug where one test wasn't calling Shutdown() on its WorkerPools. Fix a deadlock if a Worker object releases the last ref to the WorkerPool. BUG=115987 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125152

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : fix race #

Patch Set 4 : Fix deadlock bug #

Patch Set 5 : Fix test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -55 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 2 3 3 chunks +12 lines, -2 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 2 3 3 chunks +22 lines, -2 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 2 3 7 chunks +89 lines, -36 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_unittest.cc View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M content/browser/trace_subscriber_stdio_unittest.cc View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
akalin
+brettw for review
8 years, 9 months ago (2012-03-01 00:14:21 UTC) #1
akalin
On 2012/03/01 00:14:21, akalin wrote: > +brettw for review Hold off on the review, looks ...
8 years, 9 months ago (2012-03-01 11:34:20 UTC) #2
akalin
On 2012/03/01 11:34:20, akalin wrote: > On 2012/03/01 00:14:21, akalin wrote: > > +brettw for ...
8 years, 9 months ago (2012-03-01 21:28:06 UTC) #3
brettw
lgtm
8 years, 9 months ago (2012-03-02 05:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9558007/22003
8 years, 9 months ago (2012-03-06 07:21:30 UTC) #5
commit-bot: I haz the power
Try job failure for 9558007-22003 (retry) on linux_rel for step "content_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-06 08:14:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9558007/31001
8 years, 9 months ago (2012-03-06 10:03:07 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-06 14:17:36 UTC) #8
Change committed as 125152

Powered by Google App Engine
This is Rietveld 408576698