Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: content/browser/trace_subscriber_stdio_unittest.cc

Issue 9558007: Ensure that SequencedWorkerPools in tests don't outlive their tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test failures Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_unittest.cc ('k') | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/trace_subscriber_stdio_unittest.cc
diff --git a/content/browser/trace_subscriber_stdio_unittest.cc b/content/browser/trace_subscriber_stdio_unittest.cc
index 6c8531c049d1d66ef4923f4d1c9f3e17bfebf6ee..df69f7d5a72c05a56823d409b2d23b0ff1ffbc96 100644
--- a/content/browser/trace_subscriber_stdio_unittest.cc
+++ b/content/browser/trace_subscriber_stdio_unittest.cc
@@ -10,7 +10,13 @@
#include "content/public/browser/browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
-TEST(TraceSubscriberStdioTest, CanWriteDataToFile) {
+class TraceSubscriberStdioTest : public ::testing::Test {
+ private:
+ // Needed by the blocking pool (but no need to pump it).
+ MessageLoop message_loop_;
+};
+
+TEST_F(TraceSubscriberStdioTest, CanWriteDataToFile) {
ScopedTempDir trace_dir;
ASSERT_TRUE(trace_dir.CreateUniqueTempDir());
FilePath trace_file(trace_dir.path().AppendASCII("trace.txt"));
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_unittest.cc ('k') | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698