Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9540006: Fix exception reading image metadata from gdata. (Closed)

Created:
8 years, 9 months ago by SeRya
Modified:
8 years, 9 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Fix exception reading image metadata from gdata. BUG=None TEST=Manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124651

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
SeRya
8 years, 9 months ago (2012-02-29 09:12:15 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/9540006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9540006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2669 chrome/browser/resources/file_manager/js/file_manager.js:2669: if (DirectoryModel.getRootType(entry.fullPath) == Maybe, introduce new MetadataProvider?
8 years, 9 months ago (2012-02-29 11:35:18 UTC) #2
SeRya
https://chromiumcodereview.appspot.com/9540006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9540006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2669 chrome/browser/resources/file_manager/js/file_manager.js:2669: if (DirectoryModel.getRootType(entry.fullPath) == On 2012/02/29 11:35:18, dgozman wrote: > ...
8 years, 9 months ago (2012-02-29 14:17:05 UTC) #3
dgozman
LGTM
8 years, 9 months ago (2012-02-29 14:46:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/9540006/1
8 years, 9 months ago (2012-03-02 12:13:14 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 16:00:18 UTC) #6 
Change committed as 124651

Powered by Google App Engine
This is Rietveld 408576698