Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 9540006: Fix exception reading image metadata from gdata. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index 181cef580be9c024d77dd3410ba54ac836ed0776..8a3d28d34e4afb8aed682e0505a19346c84cc081 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -2666,6 +2666,14 @@ FileManager.prototype = {
callback(iconType, FileType.getPreviewArt(iconType));
}
+ if (DirectoryModel.getRootType(entry.fullPath) ==
dgozman 2012/02/29 11:35:18 Maybe, introduce new MetadataProvider?
SeRya 2012/02/29 14:17:05 Let's keep it as simple as possible on this stage.
+ DirectoryModel.RootType.GDATA) {
+ // TODO(serya): retrieve thumbnail URL with getGDataFileProperties
+ // (see http://crosbug/27030)
+ returnStockIcon();
+ return;
+ }
+
this.metadataProvider_.fetch(entry.toURL(), function (metadata) {
if (metadata.thumbnailURL) {
callback(iconType, metadata.thumbnailURL, metadata.thumbnailTransform);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698