Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 9514017: Cleanup: More random cleanup for gamepad code. (Closed)

Created:
8 years, 9 months ago by Lei Zhang
Modified:
8 years, 9 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Cleanup: More random cleanup for gamepad code. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124398

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : revert content export removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -42 lines) Patch
M content/browser/gamepad/gamepad_provider.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_provider_unittest.cc View 1 5 chunks +9 lines, -5 lines 0 comments Download
M content/browser/gamepad/platform_data_fetcher_linux.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gamepad/platform_data_fetcher_linux.cc View 1 3 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
8 years, 9 months ago (2012-02-28 22:50:46 UTC) #1
scottmg
lgtm Just make sure to check the _shared bots for the CONTENT_EXPORT removal.
8 years, 9 months ago (2012-02-28 23:00:55 UTC) #2
Lei Zhang
On 2012/02/28 23:00:55, scottmg wrote: > lgtm > > Just make sure to check the ...
8 years, 9 months ago (2012-02-29 01:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9514017/8001
8 years, 9 months ago (2012-02-29 22:08:18 UTC) #4
commit-bot: I haz the power
Presubmit check for 9514017-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-02-29 22:08:22 UTC) #5
Lei Zhang
Whoops, forgot I needed a content OWNER stamp.
8 years, 9 months ago (2012-02-29 22:12:08 UTC) #6
jam
lgtm
8 years, 9 months ago (2012-03-01 01:07:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9514017/8001
8 years, 9 months ago (2012-03-01 01:14:26 UTC) #8
commit-bot: I haz the power
Try job failure for 9514017-8001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-01 03:32:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9514017/8001
8 years, 9 months ago (2012-03-01 08:22:06 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 10:08:19 UTC) #11
Change committed as 124398

Powered by Google App Engine
This is Rietveld 408576698